usb: fsl_udc_core: check return value of create_proc_read_entry()
in [Kernel]
|
Prev: udf:super.c Fix warning: variable 'sbi' set but not used
Next: Greatly improve TSC calibration using a timer
From: Dan Carpenter on 31 Jul 2010 15:20 On Sat, Jul 31, 2010 at 09:38:20PM +0400, Kulikov Vasiliy wrote: > create_proc_read_entry() may fail, if so return -ENOMEM. > It can fail, but also we return NULL if procfs is disabled. I haven't looked at it very carefully, would this patch break the module if procfs was disabled? The same applies to the similar patches in this set. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dan Carpenter on 1 Aug 2010 07:00
On Sun, Aug 01, 2010 at 10:19:34AM +0400, Vasiliy Kulikov wrote: > On Sat, Jul 31, 2010 at 21:17 +0200, Dan Carpenter wrote: > > On Sat, Jul 31, 2010 at 09:38:20PM +0400, Kulikov Vasiliy wrote: > > > create_proc_read_entry() may fail, if so return -ENOMEM. > > > > > > > It can fail, but also we return NULL if procfs is disabled. I haven't > > looked at it very carefully, would this patch break the module if procfs > > was disabled? > Probably you are right, but many drivers in tree compare return value > with NULL. Some of them interpret this as error, some of them simply > call pr_warn("Hmm, I cannot create file in proc, strange..."). Maybe > there is more simplier way to check it without #ifdefs? > If the allocation fails, there is already a warning so no need to add another. These things are one time allocation, normally near boot up when memory is plentifull. The places that do check should be audited to make sure there isn't an unneeded dependency on PROC_FS. I would just leave the rest. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |