Prev: pps: declare variables where they are used in switch
Next: pps: unify timestamp gathering
From: Michał Nazarewicz on 5 Aug 2010 05:10
On Mon, 02 Aug 2010 20:27:46 +0200, Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> wrote:

> The bind function is only called at init time so there is no need to
> save a pointer to it in the driver struct.

This is not entirely true. How about such wording:

The bind function is often called only at init time so there is no neet
to save a pointer to it in the configuration structure.

Also note, that if you are fixing composite gadgets as well, there's also
usb_composite_driver structure and accompanying usb_composite_register()
function.

Other then that, for what it's worth, the patch looks good to me.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 5 Aug 2010 06:10
> On Thu, Aug 05, 2010 at 11:05:47AM +0200, Michał Nazarewicz wrote:
>> Also note, that if you are fixing composite gadgets as well, there's also
>> usb_composite_driver structure and accompanying usb_composite_register()
>> function.

On Thu, 05 Aug 2010 11:45:46 +0200, Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> wrote:
> This is ortogonal to my two patches, right? Will look into it later.

Yep.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 5 Aug 2010 18:40
On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote:
> The bind function is most of the time only called at init time so there is no
> need to save a pointer to it in the configuration structure.
>
> This fixes many section mismatches reported by modpost.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
> Cc: Michał Nazarewicz <m.nazarewicz(a)samsung.com>
> Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
> ---
> changes since v1:

I'm confused, can you resend what you want me to apply please?

Do I need to drop Michał's patch before applying yours?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 6 Aug 2010 04:50
On Fri, 06 Aug 2010 00:34:35 +0200, Greg KH <greg(a)kroah.com> wrote:

> On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote:
>> The bind function is most of the time only called at init time so there is no
>> need to save a pointer to it in the configuration structure.
>>
>> This fixes many section mismatches reported by modpost.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
>> Cc: Michał Nazarewicz <m.nazarewicz(a)samsung.com>
>> Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
>> ---
>> changes since v1:
>
> I'm confused, can you resend what you want me to apply please?
>
> Do I need to drop Michał's patch before applying yours?

Yep. Uwe's patches seem to be a better solution for fixing the section
mismatch. They remove the need of __ref* tags. I looked through them
and they seem fine to me.

(Also, as I realised a minute ago, my patch is incorrect.)

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: pps: declare variables where they are used in switch
Next: pps: unify timestamp gathering