vacuum_defer_cleanup_age
in [PgSql]
|
From: Heikki Linnakangas on 11 Jun 2010 06:25 On 11/06/10 05:36, Fujii Masao wrote: > vacuum_defer_cleanup_age is categorized as "Statement Behavior" > parameter in the document. On the other hand, it's categorized > as "Hot Standby" one in postgresql.conf. Why do we need to do so? Yeah, there's clearly a mismatch. I think "Hot Standby" is the right place, altough you could argue that it should be together with vacuum_freeze_min_age and vacuum_freeze_table_age too. We seem to be missing an entry for "Write-Ahead Log / Hot Standby" in the config_group_names list in guc.c. hot_standby GUC marked to beling in WAL_SETTINGS in guc.c. What's the policy with that, should all the sections in the sample config file and docs have a corresponding enum in config_group_names? I guess they should, but many of them seem to be missing. There's no separate entry in config_group_names for "Write-Ahead Log / Archiving", "Resource Usage / Cost-Based Vacuum Delay" and "Resource Usage / Asynchronous Behavior" either, for example. Should I add entries in the enum for all the missing ones? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Fujii Masao on 11 Jun 2010 09:22 On Fri, Jun 11, 2010 at 7:25 PM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > Yeah, there's clearly a mismatch. I think "Hot Standby" is the right place, > altough you could argue that it should be together with > vacuum_freeze_min_age and vacuum_freeze_table_age too. > > We seem to be missing an entry for "Write-Ahead Log / Hot Standby" in the > config_group_names list in guc.c. hot_standby GUC marked to beling in > WAL_SETTINGS in guc.c. > > What's the policy with that, should all the sections in the sample config > file and docs have a corresponding enum in config_group_names? I guess they > should, but many of them seem to be missing. There's no separate entry in > config_group_names for "Write-Ahead Log / Archiving", "Resource Usage / > Cost-Based Vacuum Delay" and "Resource Usage / Asynchronous Behavior" > either, for example. > > Should I add entries in the enum for all the missing ones? +1. This seems sensible. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Pages: 1 Prev: [HACKERS] vacuum_defer_cleanup_age Next: server authentication over Unix-domain sockets |