Prev: [PATCH -mm] memcg: avoid css_get
Next: X:2252 conflicting memory types 40000000-48000000 uncached-minus<->write-combining
From: Jean-Francois Moine on 8 Jul 2010 02:50
On Wed, 7 Jul 2010 21:46:18 -0700
"Justin P. Mattock" <justinmattock(a)gmail.com> wrote:

> This fixes a warning I'm seeing when building:
> CC [M] drivers/media/video/gspca/gspca.o
> drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
> drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not
> in enumerated type 'enum v4l2_memory'

Hi Justin,

I don't agree with your patch: the value GSPCA_MEMORY_READ must not be
seen by user applications.

The warning may be simply fixed by (change the line numbers):

--- gspca.c~ 2010-07-08 08:15:14.000000000 +0200
+++ gspca.c 2010-07-08 08:28:52.000000000 +0200
@@ -1467,7 +1467,8 @@ static int vidioc_reqbufs(struct file *f
struct gspca_dev *gspca_dev = priv;
int i, ret = 0, streaming;

- switch (rb->memory) {
+ i = rb->memory; /* (avoid compilation warning) */
+ switch (i) {
case GSPCA_MEMORY_READ: /* (internal call) */
case V4L2_MEMORY_MMAP:
case V4L2_MEMORY_USERPTR:

Cheers.

--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -mm] memcg: avoid css_get
Next: X:2252 conflicting memory types 40000000-48000000 uncached-minus<->write-combining