virtio: set pci bus master enable bit
in [Kernel]
|
Prev: MIPS: Wire up recvmmsg syscall
Next: USB: Added USB_ETH_RNDIS to use instead of CONFIG_USB_ETH_RNDIS
From: Rusty Russell on 30 Nov 2009 19:10 On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote: > As all virtio devices perform DMA, we > must enable bus mastering for them to be > spec compliant. > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > drivers/virtio/virtio_pci.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index 28d9cf7..717bae1 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev, > goto out_req_regions; > > pci_set_drvdata(pci_dev, vp_dev); > + pci_set_master(pci_dev); I can believe this, but I have no idea if it's right. I've applied it, and hope Jesse will comment if there's something wrong with it. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jesse Barnes on 4 Dec 2009 18:20
On Tue, 1 Dec 2009 10:34:01 +1030 Rusty Russell <rusty(a)rustcorp.com.au> wrote: > On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote: > > As all virtio devices perform DMA, we > > must enable bus mastering for them to be > > spec compliant. > > > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > > --- > > drivers/virtio/virtio_pci.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/virtio/virtio_pci.c > > b/drivers/virtio/virtio_pci.c index 28d9cf7..717bae1 100644 > > --- a/drivers/virtio/virtio_pci.c > > +++ b/drivers/virtio/virtio_pci.c > > @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct > > pci_dev *pci_dev, goto out_req_regions; > > > > pci_set_drvdata(pci_dev, vp_dev); > > + pci_set_master(pci_dev); > > I can believe this, but I have no idea if it's right. I've applied > it, and hope Jesse will comment if there's something wrong with it. Nope, nothing wrong with that afaict. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |