From: David Southwell on
> On 07/14/2010 04:20, David Southwell wrote:
> > his morning I was just going to test your patch when I saw you had
> > committed the patch. I updated my ports and tested the result - which
> > now produces a different error.
>
> ...
>
> > Syntax error: end of file unexpected (expecting "fi")
> > *** Error code 2
>
> Confirmed, the last few characters are missing from the commit. I caught
> this a few minutes ago myself.
>
> Attached is a rectifying diff...
I placed the .diff file in the multimedia/vlc/files/ directory but still
received the same error. Clearly that is not the way to apply it.

Forgive my ignorance but how should this file be applied?

David

Photographic Artist
Permanent Installations & Design
Creative Imagery and Advanced Digital Techniques
High Dynamic Range Photography & Official Portraiture
Combined darkroom & digital creations
& Systems Adminstrator for the vizion2000.net network
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Wesley Shields on
On Wed, Jul 14, 2010 at 04:57:24AM -0400, Joseph S. Atkinson wrote:
> On 07/14/2010 04:20, David Southwell wrote:
> > his morning I was just going to test your patch when I saw you had committed
> > the patch. I updated my ports and tested the result - which now produces a
> > different error.
> >
>
> ...
>
> > Syntax error: end of file unexpected (expecting "fi")
> > *** Error code 2
>
> Confirmed, the last few characters are missing from the commit. I caught this a
> few minutes ago myself.
>
> Attached is a rectifying diff...

> --- /usr/ports/multimedia/vlc/Makefile 2010-07-13 21:22:28.000000000 -0400
> +++ Makefile 2010-07-14 04:44:28.000000000 -0400
> @@ -319,7 +319,7 @@
> .endif
>
> .if defined(WITH_GNOMEVFS)
> -USE_GNOME= gnomevfs
> +USE_GNOME= gnomevfs2
> CONFIGURE_ARGS+=--enable-gnomevfs
> .else
> COFIGURE_ARGS+=--disable-gnomevfs
> @@ -672,7 +672,8 @@
> ${SED} -e 's|^|share/${dir}/|' >> ${PLIST} \
> && ${FIND} -d * -type d | \
> ${SED} -e 's|^|@dirrmtry share/${dir}/|' >> ${PLIST} \
> - && ${ECHO_CMD} "@dirrmtry share/${dir}" >> ${PLIST}
> + && ${ECHO_CMD} "@dirrmtry share/${dir}" >> ${PLIST} ; \
> + fi
> .endfor
> .if !defined(NOPORTDOCS)
> cd ${FAKEDIR}/share/doc && ${FIND} -s * -type f -o -type l | \

You're right. I've just committed these fixes. Sorry about that.

-- WXS
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: David Southwell on
> On Wed, Jul 14, 2010 at 04:57:24AM -0400, Joseph S. Atkinson wrote:
> > On 07/14/2010 04:20, David Southwell wrote:
> > > his morning I was just going to test your patch when I saw you had
> > > committed the patch. I updated my ports and tested the result - which
> > > now produces a different error.
> >
> > ...
> >
> > > Syntax error: end of file unexpected (expecting "fi")
> > > *** Error code 2
> >
> > Confirmed, the last few characters are missing from the commit. I caught
> > this a few minutes ago myself.
> >
> > Attached is a rectifying diff...
> >
> > --- /usr/ports/multimedia/vlc/Makefile 2010-07-13 21:22:28.000000000
> > -0400 +++ Makefile 2010-07-14 04:44:28.000000000 -0400
> > @@ -319,7 +319,7 @@
> >
> > .endif
> >
> > .if defined(WITH_GNOMEVFS)
> >
> > -USE_GNOME= gnomevfs
> > +USE_GNOME= gnomevfs2
> >
> > CONFIGURE_ARGS+=--enable-gnomevfs
> > .else
> > COFIGURE_ARGS+=--disable-gnomevfs
> >
> > @@ -672,7 +672,8 @@
> >
> > ${SED} -e 's|^|share/${dir}/|' >> ${PLIST} \
> > && ${FIND} -d * -type d | \
> > ${SED} -e 's|^|@dirrmtry share/${dir}/|' >> ${PLIST} \
> >
> > - && ${ECHO_CMD} "@dirrmtry share/${dir}" >> ${PLIST}
> > + && ${ECHO_CMD} "@dirrmtry share/${dir}" >> ${PLIST} ; \
> > + fi
> >
> > .endfor
> > .if !defined(NOPORTDOCS)
> >
> > cd ${FAKEDIR}/share/doc && ${FIND} -s * -type f -o -type l | \
>
> You're right. I've just committed these fixes. Sorry about that.
>
> -- WXS
Great - just updated to latest - Build and installs cleanly.

Thanks for your work - it is appreciated

David

Photographic Artist
Permanent Installations & Design
Creative Imagery and Advanced Digital Techniques
High Dynamic Range Photography & Official Portraiture
Combined darkroom & digital creations
& Systems Adminstrator for the vizion2000.net network
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"