Prev: Your Email Address has been awarded $800.000 usd at the United nation scam compensation programm 2010
Next: [PATCH] fcntl.h: define AT_EACCESS
From: KOSAKI Motohiro on 15 Apr 2010 23:00
> Two variables are declared that are unnecessary in shrink_zone() as they
> already exist int the scan_control. Remove them
>
> Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>

ok.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com>


> ---
> mm/vmscan.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a374879..a232ad6 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1633,8 +1633,6 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc)
> {
> unsigned long nr[NR_LRU_LISTS];
> unsigned long nr_to_scan;
> - unsigned long nr_reclaimed = sc->nr_reclaimed;
> - unsigned long nr_to_reclaim = sc->nr_to_reclaim;
> enum lru_list l;
>
> calc_scan_trybatch(zone, sc, nr);
> @@ -1647,7 +1645,7 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc)
> nr[l], SWAP_CLUSTER_MAX);
> nr[l] -= nr_to_scan;
>
> - nr_reclaimed += shrink_list(l, nr_to_scan,
> + sc->nr_reclaimed += shrink_list(l, nr_to_scan,
> zone, sc);
> }
> }
> @@ -1659,13 +1657,11 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc)
> * with multiple processes reclaiming pages, the total
> * freeing target can get unreasonably large.
> */
> - if (nr_reclaimed >= nr_to_reclaim &&
> + if (sc->nr_reclaimed >= sc->nr_to_reclaim &&
> sc->priority < DEF_PRIORITY)
> break;
> }
>
> - sc->nr_reclaimed = nr_reclaimed;
> -
> /*
> * Even if we did not try to evict anon pages at all, we want to
> * rebalance the anon lru active/inactive ratio.
> --
> 1.6.5
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Weiner on 16 Apr 2010 19:10
On Fri, Apr 16, 2010 at 11:51:26AM +0900, KOSAKI Motohiro wrote:
> > Two variables are declared that are unnecessary in shrink_zone() as they
> > already exist int the scan_control. Remove them
> >
> > Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>
>
> ok.
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com>

You confuse me, you added the local variables yourself in 01dbe5c9
for performance reasons. Doesn't that still hold?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Your Email Address has been awarded $800.000 usd at the United nation scam compensation programm 2010
Next: [PATCH] fcntl.h: define AT_EACCESS