Prev: [ANNOUNCE] Linux Security Summit 2010 - Schedule Published
Next: 2.6.35-rc3 - include/linux/fdtable.h:85 invoked rcu_dereference_check() without protection!
From: Andrew Morton on 16 Jun 2010 19:50
On Mon, 14 Jun 2010 12:17:50 +0100
Mel Gorman <mel(a)csn.ul.ie> wrote:

> shrink_page_list() sets up a pagevec to release pages as according as they
> are free. It uses significant amounts of stack on the pagevec. This
> patch adds pages to be freed via pagevec to a linked list which is then
> freed en-masse at the end. This avoids using stack in the main path that
> potentially calls writepage().
>

hm, spose so. I cen't see any trivial way to eliminate the local
pagevec there.

> + if (pagevec_count(&freed_pvec))
> + __pagevec_free(&freed_pvec);
> ...
> - if (pagevec_count(&freed_pvec))
> - __pagevec_free(&freed_pvec);

That's an open-coded pagevec_free().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [ANNOUNCE] Linux Security Summit 2010 - Schedule Published
Next: 2.6.35-rc3 - include/linux/fdtable.h:85 invoked rcu_dereference_check() without protection!