Prev: core dumping on NFS mounted directory
Next: x86, pci: Handle fallout pci devices with peer root bus
From: Rik van Riel on 14 Jun 2010 14:10
On 06/14/2010 07:17 AM, Mel Gorman wrote:
> From: KOSAKI Motohiro<kosaki.motohiro(a)jp.fujitsu.com>
>
> Now, max_scan of shrink_inactive_list() is always passed less than
> SWAP_CLUSTER_MAX. then, we can remove scanning pages loop in it.
> This patch also help stack diet.
>
> detail
> - remove "while (nr_scanned< max_scan)" loop
> - remove nr_freed (now, we use nr_reclaimed directly)
> - remove nr_scan (now, we use nr_scanned directly)
> - rename max_scan to nr_to_scan
> - pass nr_to_scan into isolate_pages() directly instead
> using SWAP_CLUSTER_MAX
>
> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro(a)jp.fujitsu.com>
> Reviewed-by: Johannes Weiner<hannes(a)cmpxchg.org>

Other than the weird whitespace below,

Reviewed-by: Rik van Riel <riel(a)redhat.com>

> + /*
> + * If we are direct reclaiming for contiguous pages and we do
> + * not reclaim everything in the list, try again and wait
> + * for IO to complete. This will stall high-order allocations
> + * but that should be acceptable to the caller
> + */
> + if (nr_reclaimed< nr_taken&& !current_is_kswapd()&& sc->lumpy_reclaim_mode) {
> + congestion_wait(BLK_RW_ASYNC, HZ/10);

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mel Gorman on 15 Jun 2010 06:20
On Mon, Jun 14, 2010 at 02:06:13PM -0400, Rik van Riel wrote:
> On 06/14/2010 07:17 AM, Mel Gorman wrote:
>> From: KOSAKI Motohiro<kosaki.motohiro(a)jp.fujitsu.com>
>>
>> Now, max_scan of shrink_inactive_list() is always passed less than
>> SWAP_CLUSTER_MAX. then, we can remove scanning pages loop in it.
>> This patch also help stack diet.
>>
>> detail
>> - remove "while (nr_scanned< max_scan)" loop
>> - remove nr_freed (now, we use nr_reclaimed directly)
>> - remove nr_scan (now, we use nr_scanned directly)
>> - rename max_scan to nr_to_scan
>> - pass nr_to_scan into isolate_pages() directly instead
>> using SWAP_CLUSTER_MAX
>>
>> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro(a)jp.fujitsu.com>
>> Reviewed-by: Johannes Weiner<hannes(a)cmpxchg.org>
>
> Other than the weird whitespace below,
>

Not sure where this came out of. It's not in my local patch file nor in
my working tree. Very odd.

> Reviewed-by: Rik van Riel <riel(a)redhat.com>
>

Thanks

>> + /*
>> + * If we are direct reclaiming for contiguous pages and we do
>> + * not reclaim everything in the list, try again and wait
>> + * for IO to complete. This will stall high-order allocations
>> + * but that should be acceptable to the caller
>> + */
>> + if (nr_reclaimed< nr_taken&& !current_is_kswapd()&& sc->lumpy_reclaim_mode) {
>> + congestion_wait(BLK_RW_ASYNC, HZ/10);
>
> --
> All rights reversed
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: core dumping on NFS mounted directory
Next: x86, pci: Handle fallout pci devices with peer root bus