wm8350-core: fix wrong kfree in error path
in [Kernel]
|
Prev: media: Add a cached version of the contiguous video buffers
Next: [PATCH 0/3] SysRq: do not pass tty argument around
From: Mark Brown on 4 Aug 2010 04:00 On Wed, Aug 04, 2010 at 09:54:21AM +0800, Axel Lin wrote: > This patch includes below fixes: > 1. fix wm8350_create_cache error path > make sure wm8350->reg_cache is freed in error path. > 2. fix wm8350_device_init error path > no need to kfree(wm8350->reg_cache) in the case of goto out. > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Please remember to always submit separate patches for separate issues, mixing things together makes review harder and means that if there's a problem with one part of what you've done the entire patch gets held up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 5 Aug 2010 12:30
Hi Axel, On Wed, Aug 04, 2010 at 09:54:21AM +0800, Axel Lin wrote: > This patch includes below fixes: > 1. fix wm8350_create_cache error path > make sure wm8350->reg_cache is freed in error path. > 2. fix wm8350_device_init error path > no need to kfree(wm8350->reg_cache) in the case of goto out. Applied, although as Mark pointed out, I'd have preferred 2 patches here. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |