wm8960: fix compile error
in [Kernel]
|
Prev: irq: add tracepoint to softirq_raise
Next: sysfs: add entry to indicate network interfaces with random MAC address
From: Mark Brown on 20 Jul 2010 07:10 On Tue, Jul 20, 2010 at 05:49:22PM +0800, Axel Lin wrote: > This patch is against Liam's multi-component branch. Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> but please do try to bear in mind the feedback you've previously been given about formatting your patches so they can be easily applied. You probably also want to look at the CC list for your patches, I'm not sure why you're CCing Tejun here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Axel Lin on 20 Jul 2010 11:10 hi Mark, 2010/7/20 Mark Brown <broonie(a)opensource.wolfsonmicro.com>: > On Tue, Jul 20, 2010 at 05:49:22PM +0800, Axel Lin wrote: > >> This patch is against Liam's multi-component branch. > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > but please do try to bear in mind the feedback you've previously been > given about formatting your patches so they can be easily applied. �You I'm a little bit confused about the meaning of "formatting your patches"? Do you mean my patches cannot be applied by git am command? or? ( I tried the git am command with the mail I sent and it looks ok ) > probably also want to look at the CC list for your patches, I'm not sure > why you're CCing Tejun here. I get the CC list by get_maintainer.pl. Looks like the script gives me wrong CC list. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mark Brown on 20 Jul 2010 11:20
On Tue, Jul 20, 2010 at 11:02:37PM +0800, Axel Lin wrote: > 2010/7/20 Mark Brown <broonie(a)opensource.wolfsonmicro.com>: > > but please do try to bear in mind the feedback you've previously been > > given about formatting your patches so they can be easily applied. �You > I'm a little bit confused about the meaning of "formatting your patches"? > Do you mean my patches cannot be applied by git am command? or? > ( I tried the git am command with the mail I sent and it looks ok ) In this case the main thing is the subject line which is not consistent with other subject lines for patches in this area of code. This sort of stuff is particularly important when you're submitting large numbers of very small fixes. > > probably also want to look at the CC list for your patches, I'm not sure > > why you're CCing Tejun here. > I get the CC list by get_maintainer.pl. Looks like the script gives me wrong > CC list. Yes, you need to apply a bit of taste to the output - it's inclined to generate false positives. For matches from MAINTAINERS it's good but for things generated from the git logs it can easily miss people or pick up people who've been doing kernel wide cleanup work. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |