x86, UV: BAU performance and error recovery
in [Kernel]
|
From: Ingo Molnar on 28 May 2010 05:40 * Cliff Wickman <cpw(a)sgi.com> wrote: > Ingo, > This patch replaces the patch of the same name, from March 2010. > You had queued it up for v2.6.35 on April 14. FYI, those bits are upstream now: b8f7fb1: x86, UV: Improve BAU performance and error recovery And will be in v2.6.35. Please send your latest improvements against latest -tip. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 May 2010 12:50 On Fri, May 28, 2010 at 09:30:25AM -0700, H. Peter Anvin wrote: > On 05/28/2010 06:33 AM, Cliff Wickman wrote: > > - adds modification of tuning variables through /proc/sgi_uv > > Adding new directories in /proc for a proprietary architecture is > frowned upon, to put it mildly. At the very least try to find a place > in sysfs for it. > > [Cc: gregkh in order to find a place in sysfs] Hm, what type of files are you needing here? Do they corrispond with any specific hardware devices? If so, just put them on the hardware devices in sysfs. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 28 May 2010 12:50 On 05/28/2010 06:33 AM, Cliff Wickman wrote: > - adds modification of tuning variables through /proc/sgi_uv Adding new directories in /proc for a proprietary architecture is frowned upon, to put it mildly. At the very least try to find a place in sysfs for it. [Cc: gregkh in order to find a place in sysfs] The other thing, please don't mix bug fixes and new features. They should be separate features. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Cliff Wickman on 28 May 2010 15:50 On Fri, May 28, 2010 at 09:47:25AM -0700, Greg KH wrote: > On Fri, May 28, 2010 at 09:30:25AM -0700, H. Peter Anvin wrote: > > On 05/28/2010 06:33 AM, Cliff Wickman wrote: > > > - adds modification of tuning variables through /proc/sgi_uv > > > > Adding new directories in /proc for a proprietary architecture is > > frowned upon, to put it mildly. At the very least try to find a place > > in sysfs for it. > > > > [Cc: gregkh in order to find a place in sysfs] > > Hm, what type of files are you needing here? Do they corrispond with > any specific hardware devices? If so, just put them on the hardware > devices in sysfs. > > thanks, > > greg k-h There is an SGI-specific directory in sysfs: /sys/firmware/sgi_uv though the tuning variables for the handling of the hardware Broadcast Assist Unit don't fit there very logically. The BAU's statistics are already displayed through the UV-only /proc/sgi_uv/ptc_statistics. This was deemed necessary because of the potentially very large size of that file --- it is still true that a /sys file is limited to one page, is it not? We wanted to minimize the overhead of the monitoring tools that read those statistics. And the BAU tuning is related to those statistics. That's why I chose to put them along side, in /proc/sgi_uv/bau_tunables. Even though it is a very small file. Does that logic hold any water? -Cliff -- Cliff Wickman SGI cpw(a)sgi.com (651) 683-3824 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 May 2010 18:30
On Fri, May 28, 2010 at 02:43:35PM -0500, Cliff Wickman wrote: > > On Fri, May 28, 2010 at 09:47:25AM -0700, Greg KH wrote: > > On Fri, May 28, 2010 at 09:30:25AM -0700, H. Peter Anvin wrote: > > > On 05/28/2010 06:33 AM, Cliff Wickman wrote: > > > > - adds modification of tuning variables through /proc/sgi_uv > > > > > > Adding new directories in /proc for a proprietary architecture is > > > frowned upon, to put it mildly. At the very least try to find a place > > > in sysfs for it. > > > > > > [Cc: gregkh in order to find a place in sysfs] > > > > Hm, what type of files are you needing here? Do they corrispond with > > any specific hardware devices? If so, just put them on the hardware > > devices in sysfs. > > > > thanks, > > > > greg k-h > > There is an SGI-specific directory in sysfs: /sys/firmware/sgi_uv > though the tuning variables for the handling of the hardware Broadcast > Assist Unit don't fit there very logically. > > The BAU's statistics are already displayed through the UV-only > /proc/sgi_uv/ptc_statistics. This was deemed necessary because of the > potentially very large size of that file --- it is still true that a /sys file > is limited to one page, is it not? It is limited to one single value, which would never be larger than a page, so yes, it is limited to one page. What kind of information are you showing here? Should this thing just be in debugfs instead? You can do whatever you want there. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |