Prev: [PATCH 04/40] trace, powerpc: Implement raw syscall tracepoints on PowerPC
Next: [PATCH 06/40] x86: add arch_compat_syscall_addr()
From: Christoph Hellwig on 24 Jun 2010 10:40
On Wed, Jun 23, 2010 at 12:23:44PM -0700, H. Peter Anvin wrote:
> >> arch/s390/kernel/sys_s390.c:SYSCALL_DEFINE(s390_fallocate)(int fd, int mode, loff_t offset,
> >> arch/sparc/kernel/sys_sparc_64.c:SYSCALL_DEFINE1(sparc_pipe_real, struct pt_regs *, regs)
> >
> > In fact we sort of wanted to standardize the name of arch overriden compat
> > syscalls, so that userspace programs playing with syscalls tracing won't have
> > to deal with arch naming differences.
> >
>
> That seems totally wrong in so many ways.
>
> What userspace sees is the system call name, e.g. fallocate or pipe. It
> should *not* be visible to userspace that there is an arch-specici
> implementation.

This is really just the in-kernel name. With tracing we export it to
userspace, so agreed that we should stay consistent. We need a good
way to override both native and compat system calls with arch version
to always export the sys_ / compat_sys names.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: [PATCH 04/40] trace, powerpc: Implement raw syscall tracepoints on PowerPC
Next: [PATCH 06/40] x86: add arch_compat_syscall_addr()