x86, hpet.c: Changed delayed_work to work when delay is 0
in [Kernel]
|
Prev: Sofort Geld verdienen - nur für Sie
Next: [PATCH] numa x86_64 use generic percpu var numa_node_id implementation fix3 [was Re: mmotm 2010-05-14-13-33 uploaded]
From: Venkatesh Pallipadi on 17 May 2010 21:40 Thanks for sending the patch. A comment below. On Sat, May 15, 2010 at 8:27 AM, Leonardo de S� Alt <leonardoaltt(a)gmail.com> wrote: > Here a delayed_work was used with delay 0, so it was changed to work. > It avoids a timer set up and the work is directly queued, providing > less use of memory and more performance. > > Signed-off-by: Leonardo de S� Alt <leonardoaltt(a)gmail.com> > > --- > �arch/x86/kernel/hpet.c | � �6 ++---- > �1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c > index a198b7c..4516ba1 100644 > --- a/arch/x86/kernel/hpet.c > +++ b/arch/x86/kernel/hpet.c > @@ -724,12 +724,10 @@ static int hpet_cpuhp_notify(struct notifier_block *n, > > � � � �switch (action & 0xf) { > � � � �case CPU_ONLINE: > - � � � � � � � INIT_DELAYED_WORK_ON_STACK(&work.work, hpet_work); > + � � � � � � � INIT_WORK_ON_STACK(&work.work.work, hpet_work); Can you also change work in hpet_work_struct to work_struct. That should make things a bit more cleaner. Thanks, Venki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |