x86,kgdb: Always initialize the hw breakpoint attribute
in [Kernel]
|
Prev: [PATCH 1/1] x86,kgdb: Always initialize the hw breakpoint attribute
Next: [PATCH] Staging: quatech_usb2: fix coding style issues
From: Frederic Weisbecker on 30 Mar 2010 15:20 On Tue, Mar 30, 2010 at 02:05:07PM -0500, Jason Wessel wrote: > It is required to call hw_breakpoint_init() on an attr before using it > in any other calls. This fixes the problem where kgdb will sometimes > fail to initialize on x86_64. > > CC: Ingo Molnar <mingo(a)elte.hu> > CC: stable(a)kernel.org > Signed-off-by: Jason Wessel <jason.wessel(a)windriver.com> > Acked-by: Frederic Weisbecker <fweisbec(a)gmail.com> Queued for perf/urgent, thanks! > --- > arch/x86/kernel/kgdb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c > index bfba601..b2258ca 100644 > --- a/arch/x86/kernel/kgdb.c > +++ b/arch/x86/kernel/kgdb.c > @@ -618,8 +618,8 @@ int kgdb_arch_init(void) > * portion of kgdb because this operation requires mutexs to > * complete. > */ > + hw_breakpoint_init(&attr); > attr.bp_addr = (unsigned long)kgdb_arch_init; > - attr.type = PERF_TYPE_BREAKPOINT; > attr.bp_len = HW_BREAKPOINT_LEN_1; > attr.bp_type = HW_BREAKPOINT_W; > attr.disabled = 1; > -- > 1.5.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |