x86, mrst: remove unused mrst_identify_cpu()
in [Kernel]
|
From: H. Peter Anvin on 25 Jul 2010 01:10 Jacob, is this obsolete or something that will be needed in future versions? It seems that either __mrst_cpu_chip should be killed off, or read-only users should be using the inline instead of __mrst_cpu_chip directly. -hpa On 07/24/2010 09:50 PM, Javier Martinez Canillas wrote: > mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it. > > Signed-off-by: Javier Martinez Canillas <martinez.javier(a)gmail.com> > --- > arch/x86/include/asm/mrst.h | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h > index 1635074..0d0e702 100644 > --- a/arch/x86/include/asm/mrst.h > +++ b/arch/x86/include/asm/mrst.h > @@ -26,10 +26,6 @@ enum mrst_cpu_type { > }; > > extern enum mrst_cpu_type __mrst_cpu_chip; > -static enum mrst_cpu_type mrst_identify_cpu(void) > -{ > - return __mrst_cpu_chip; > -} > > enum mrst_timer_options { > MRST_TIMER_DEFAULT, -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 25 Jul 2010 06:50 On Sun, 25 Jul 2010 00:50:38 -0400 Javier Martinez Canillas <martinez.javier(a)gmail.com> wrote: > mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it. NAK This is stuff being merged. If you are going to try and remove stuff, -next is not the place to track ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 25 Jul 2010 06:50 On Sat, 24 Jul 2010 22:04:45 -0700 "H. Peter Anvin" <hpa(a)zytor.com> wrote: > Jacob, is this obsolete or something that will be needed in future versions? > > It seems that either __mrst_cpu_chip should be killed off, or read-only > users should be using the inline instead of __mrst_cpu_chip directly. And how is the inline going to access the variable if the variable isn't global ... Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 25 Jul 2010 15:00 On 07/25/2010 03:55 AM, Alan Cox wrote: > On Sat, 24 Jul 2010 22:04:45 -0700 > "H. Peter Anvin" <hpa(a)zytor.com> wrote: > >> Jacob, is this obsolete or something that will be needed in future versions? >> >> It seems that either __mrst_cpu_chip should be killed off, or read-only >> users should be using the inline instead of __mrst_cpu_chip directly. > > And how is the inline going to access the variable if the variable isn't > global ... > > Alan Well, of course it needs to be global. The "or" in the above sentence is an xor. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [PATCH] x86, mrst: remove unused mrst_identify_cpu() Next: ACCOUNT UPGRADE |