Prev: [kernel build bug]
Next: mmotm 2010-01-28-01-36 uploaded (media/radio/saa7706h.c)
From: Linus Torvalds on 28 Jan 2010 14:00


On Thu, 28 Jan 2010, Yinghai Lu wrote:
> @@ -43,7 +43,7 @@ static void __devinit pci_root_bus_res(s
> {
> u16 word;
> u32 dword;
> - struct pci_root_info *info;
> + struct pci_root_info info;

That structure is something like a kilobyte in size, please don't put
those things on the stack (sixteen "struct resource" entries).

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Olivier Galibert on 28 Jan 2010 14:40
On Thu, Jan 28, 2010 at 11:10:14AM -0800, Yinghai Lu wrote:
>
> don't use them for peer pci root bus resource yet.
> so could cross check _CRS results
>
> -v2: dont put info struct in stack according to Linus.
> because that is kbytes big

No kfree?

OG.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 28 Jan 2010 16:10
On 01/28/2010 11:30 AM, Olivier Galibert wrote:
> On Thu, Jan 28, 2010 at 11:10:14AM -0800, Yinghai Lu wrote:
>>
>> don't use them for peer pci root bus resource yet.
>> so could cross check _CRS results
>>
>> -v2: dont put info struct in stack according to Linus.
>> because that is kbytes big
>
> No kfree?

thanks.

anyway Jesse don't need print out.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [kernel build bug]
Next: mmotm 2010-01-28-01-36 uploaded (media/radio/saa7706h.c)