Prev: hwmon: (coretemp) Detect the thermal sensors by CPUID
Next: [PATCH] Handle instruction cache maintenance fault properly
From: Robert Richter on 10 May 2010 08:50
On 08.05.10 07:25:51, Cyrill Gorcunov wrote:
> If an event is not RAW we should exit p4_hw_config
> early but call x86_setup_perfctr as well.
>
> CC: Peter Zijlstra <peterz(a)infradead.org>
> CC: Ingo Molnar <mingo(a)elte.hu>
> CC: Frederic Weisbecker <fweisbec(a)gmail.com>
> CC: Lin Ming <ming.m.lin(a)intel.com>
> CC: Robert Richter <robert.richter(a)amd.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov(a)openvz.org>
> ---
>
> Robert, if only I'm not missing something this is
> a side effect of commit 9d0fcba67e47ff398a6fa86476d4884d472dc98a,
> wonders why don't we hit it earlier. Am I wrong?

Yes, that's true, the function had have two exit points. Thanks for
the fix.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter(a)amd.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: hwmon: (coretemp) Detect the thermal sensors by CPUID
Next: [PATCH] Handle instruction cache maintenance fault properly