x86, xsave: some code cleanups and reworks, -v2
in [Kernel]
|
Prev: x86, xsave: disable xsave in i387 emulation mode
Next: KVM: MMU: fix page dirty tracking lost while sync page
From: Suresh Siddha on 21 Jul 2010 14:30 On Wed, 2010-07-21 at 10:03 -0700, Robert Richter wrote: > Hans Peter, Suresh, and Cyrill, thanks for your feedback. > > This is version 2 of the patch series. > > Patches 2, 4, 7 are unchanged compared to -v1. > > Patch 1 folds the initialization code into one patch. fpu_init() is > now called before xsave_init(). xsave_init() can later overwrite > xstate_size based on xstate features. > > Patch 3 replaces all hardcoded XSTATE_CPUID values know. cpuid_level > is now taken from boot_cpu_data. > > Patches 5 and 6 are new: > * add __init attribute to setup_xstate_features() > * disable xsave in i387 emulation mode Apart from the cleanup comments that I had for "[PATCH 6/7] x86, xsave: disable xsave in i387 emulation mode", all other patches look good to me. Acked-by: Suresh Siddha <suresh.b.siddha(a)intel.com> Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 21 Jul 2010 17:00 On 07/21/2010 10:03 AM, Robert Richter wrote: > Hans Peter, Suresh, and Cyrill, thanks for your feedback. > > This is version 2 of the patch series. > > Patches 2, 4, 7 are unchanged compared to -v1. > > Patch 1 folds the initialization code into one patch. fpu_init() is > now called before xsave_init(). xsave_init() can later overwrite > xstate_size based on xstate features. > > Patch 3 replaces all hardcoded XSTATE_CPUID values know. cpuid_level > is now taken from boot_cpu_data. > > Patches 5 and 6 are new: > * add __init attribute to setup_xstate_features() > * disable xsave in i387 emulation mode > Please note that I did integrate some of your patches already. I might need you to rebase; I'll know in a few minutes. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 21 Jul 2010 17:10
On 07/21/2010 01:55 PM, H. Peter Anvin wrote: > > Please note that I did integrate some of your patches already. I might > need you to rebase; I'll know in a few minutes. > Nevermind, you had already seen that. I'm going to hold off on 6/7 to let you address Suresh' comments, and will look for a sensible place to put 7/7. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |