Prev: [HACKERS] Windowing Qual Pushdown
Next: [HACKERS] Proposal for Byte savings in VarBit structure
From: Takahiro Itagaki on 2 Apr 2010 02:39

Andrew Dunstan <andrew(a)dunslane.net> wrote:

> Hmm. OK. Well here is a patch that tries to fix the xmlconcat error,
> anyway. It seems to work, but maybe could stand a little tightening.

Can we take the patch for 9.0? The bug is registered as an open item:
http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items

As far as the patch, I found there are still two issues even after it applied:

1. A linebreak is added at the line end DOCTYPE exists.
=# SELECT xmlconcat('foo', xmlparse(DOCUMENT '<!DOCTYPE html><html/>'));
xmlconcat
------------
foo<html/>+

(1 row)

2. DOCUMENT could have <?xml> before DOCTYPE.
=# SELECT xmlconcat('foo', xmlparse(DOCUMENT '<?xml version="1.0"?> <!DOCTYPE html> <html/>'));
xmlconcat
-----------
foo
(1 row)

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 2 Apr 2010 10:56
Takahiro Itagaki <itagaki.takahiro(a)oss.ntt.co.jp> writes:
> Can we take the patch for 9.0? The bug is registered as an open item:
> http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items

Given that there are still problems with it, applying the patch for 9.0
would mean changing the behavior of xmlconcat in 9.0 and then again in
9.1. I don't think that's a good idea. Better to leave it alone until
we have a full fix.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Takahiro Itagaki on 5 Apr 2010 00:15

Tom Lane <tgl(a)sss.pgh.pa.us> wrote:

> Takahiro Itagaki <itagaki.takahiro(a)oss.ntt.co.jp> writes:
> > Can we take the patch for 9.0? The bug is registered as an open item:
> > http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items
>
> Given that there are still problems with it, applying the patch for 9.0
> would mean changing the behavior of xmlconcat in 9.0 and then again in
> 9.1. I don't think that's a good idea. Better to leave it alone until
> we have a full fix.

Ok, I added it in ToDo list, and removed it from 9.0 open items.
better handling of PIs and DTDs in xmlconcat()

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2 3
Prev: [HACKERS] Windowing Qual Pushdown
Next: [HACKERS] Proposal for Byte savings in VarBit structure