xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL()
in [Kernel]
|
From: Patrick McHardy on 13 Apr 2010 05:30 Alexey Dobriyan wrote: > XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829 > "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition". > ALIGN() is not exported in userspace headers, which created compile problem for tc(8) > and will create problem for iptables(8). > > We can't export generic looking name ALIGN() but we can export less generic > __ALIGN_KERNEL() (suggested by Ben Hutchings). > Google knows nothing about __ALIGN_KERNEL(). > > COMPAT_XT_ALIGN() changed for symmetry. Since there haven't been any objections, I've applied your patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Patrick McHardy on 13 Apr 2010 06:10 Patrick McHardy wrote: > Alexey Dobriyan wrote: >> XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829 >> "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition". >> ALIGN() is not exported in userspace headers, which created compile problem for tc(8) >> and will create problem for iptables(8). >> >> We can't export generic looking name ALIGN() but we can export less generic >> __ALIGN_KERNEL() (suggested by Ben Hutchings). >> Google knows nothing about __ALIGN_KERNEL(). >> >> COMPAT_XT_ALIGN() changed for symmetry. > > Since there haven't been any objections, I've applied your patch. This breaks compilation by removing __ALIGN_MASK(). Please fix this up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: SO_REUSEADDR with UDP (again) Next: Fix missing of last user while dumping slab corruption log |