zram: fix build errors, depends on BLOCK
in [Kernel]
|
From: Nitin Gupta on 24 Jun 2010 00:40 On 06/24/2010 08:57 AM, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > Fix 49 zram build errors in one swoop. Examples: > > drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type > drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' > drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token > drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' > drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' > drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' > drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' > drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) > drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type > Thanks for the fix. Strangely, I didn't get any of these errors when I compiled against mainline. Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 24 Jun 2010 10:40 On 06/23/10 21:36, Nitin Gupta wrote: > On 06/24/2010 08:57 AM, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap(a)oracle.com> >> >> Fix 49 zram build errors in one swoop. Examples: >> >> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type >> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' >> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token >> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' >> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' >> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' >> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' >> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) >> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type >> > > > Thanks for the fix. Strangely, I didn't get any of these > errors when I compiled against mainline. This patch isn't against mainline, it's against linux-next. See subject's "[PATCH -next]" hint. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Nitin Gupta on 24 Jun 2010 11:50 On 06/24/2010 08:02 PM, Randy Dunlap wrote: > On 06/23/10 21:36, Nitin Gupta wrote: >> On 06/24/2010 08:57 AM, Randy Dunlap wrote: >>> From: Randy Dunlap <randy.dunlap(a)oracle.com> >>> >>> Fix 49 zram build errors in one swoop. Examples: >>> >>> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type >>> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' >>> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token >>> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' >>> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' >>> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' >>> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' >>> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) >>> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type >>> >> >> >> Thanks for the fix. Strangely, I didn't get any of these >> errors when I compiled against mainline. > > This patch isn't against mainline, it's against linux-next. > See subject's "[PATCH -next]" hint. > Randy, I understood that your patch is against linux-next. I was just wondering why the error did not come up when I applied and tested this whole zram thing against linux mainline. Anyways, thanks for the fix. Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 24 Jun 2010 12:00 On 06/24/10 08:47, Nitin Gupta wrote: > On 06/24/2010 08:02 PM, Randy Dunlap wrote: >> On 06/23/10 21:36, Nitin Gupta wrote: >>> On 06/24/2010 08:57 AM, Randy Dunlap wrote: >>>> From: Randy Dunlap <randy.dunlap(a)oracle.com> >>>> >>>> Fix 49 zram build errors in one swoop. Examples: >>>> >>>> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type >>>> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' >>>> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token >>>> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' >>>> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' >>>> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' >>>> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' >>>> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) >>>> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type >>>> >>> >>> >>> Thanks for the fix. Strangely, I didn't get any of these >>> errors when I compiled against mainline. >> >> This patch isn't against mainline, it's against linux-next. >> See subject's "[PATCH -next]" hint. >> > > Randy, I understood that your patch is against linux-next. I was just wondering > why the error did not come up when I applied and tested this whole zram thing > against linux mainline. Did you test a build with CONFIG_BLOCK disabled? > Anyways, thanks for the fix. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Nitin Gupta on 24 Jun 2010 12:10 On 06/24/2010 09:23 PM, Randy Dunlap wrote: > On 06/24/10 08:47, Nitin Gupta wrote: >> On 06/24/2010 08:02 PM, Randy Dunlap wrote: >>> On 06/23/10 21:36, Nitin Gupta wrote: >>>> On 06/24/2010 08:57 AM, Randy Dunlap wrote: >>>>> From: Randy Dunlap <randy.dunlap(a)oracle.com> >>>>> >>>>> Fix 49 zram build errors in one swoop. Examples: >>>>> >>>>> drivers/staging/zram/zram_drv.c:225: error: dereferencing pointer to incomplete type >>>>> drivers/staging/zram/zram_drv.c:226: error: implicit declaration of function 'bio_for_each_segment' >>>>> drivers/staging/zram/zram_drv.c:226: error: expected ';' before '{' token >>>>> drivers/staging/zram/zram_drv.c:281: error: implicit declaration of function 'bio_endio' >>>>> drivers/staging/zram/zram_drv.c:285: error: implicit declaration of function 'bio_io_error' >>>>> drivers/staging/zram/zram_drv.c:545: error: implicit declaration of function 'set_capacity' >>>>> drivers/staging/zram/zram_drv.c:548: error: implicit declaration of function 'queue_flag_set_unlocked' >>>>> drivers/staging/zram/zram_drv.c:548: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function) >>>>> drivers/staging/zram/zram_drv.c:548: error: dereferencing pointer to incomplete type >>>>> >>>> >>>> >>>> Thanks for the fix. Strangely, I didn't get any of these >>>> errors when I compiled against mainline. >>> >>> This patch isn't against mainline, it's against linux-next. >>> See subject's "[PATCH -next]" hint. >>> >> >> Randy, I understood that your patch is against linux-next. I was just wondering >> why the error did not come up when I applied and tested this whole zram thing >> against linux mainline. > > Did you test a build with CONFIG_BLOCK disabled? > Ah, now I got it. No, I didn't test with CONFIG_BLOCK disabled. Thanks, Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [patch 07/52] fs: brlock vfsmount_lock Next: I am Mr.Edwin Hui Hin Shung |