9.0beta2 - server crash when using HS + SR
in [PgSql]
|
Prev: Large (almost 50%!) performancedrop after upgrading to 8.4.4?
Next: 9.0b1: "ERROR: btree index keys must be ordered by attribute"
From: Bruce Momjian on 30 Jun 2010 19:41 Tom Lane wrote: > Bruce Momjian <bruce(a)momjian.us> writes: > > The attached patch shows the hint only during recovery. > > BTW, it would be easier and more consistent with the rest of the code to > look at InRecovery, instead of messing around with the function > signature. And the usual way to emit a hint conditionally is > > (InRecovery ? errhint(...) : 0) > > rather than duplicate a lot of surrounding code. Thanks for the "hints". I was thinking there was a way to use ? : for the hint, but couldn't find an example. I see examples now. Updated patch attached. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. +
From: Bruce Momjian on 1 Jul 2010 22:44
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <bruce(a)momjian.us> writes: > > > The attached patch shows the hint only during recovery. > > > > BTW, it would be easier and more consistent with the rest of the code to > > look at InRecovery, instead of messing around with the function > > signature. And the usual way to emit a hint conditionally is > > > > (InRecovery ? errhint(...) : 0) > > > > rather than duplicate a lot of surrounding code. > > Thanks for the "hints". I was thinking there was a way to use ? : for > the hint, but couldn't find an example. I see examples now. Updated > patch attached. Applied. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. + -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |