From: Robert Haas on
On Feb 17, 2010, at 11:34 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote:
> Which leads me to the thought that rather than postponing running
> pgindent until late beta, maybe we should run it *now*, and get the
> bulk of its work done for the new code in 9.0. Then people would have
> a solid base to patch against, rather than having to expect a major
> merge hassle at the end of beta.

I was going to write an email proposing something along these lines,
too - so +1 from me.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Bruce Momjian on
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> writes:
> > Magnus Hagander wrote:
> >> Doesn't that require that all pgindent runs produce the same output?
>
> > True. So everyone will have to send their patches to Bruce for bit-rot
> > fixing ;-)
>
> I think Bruce ought to publish the specific typedef list he uses for
> each run (maybe commit it in src/tools/pgindent/). In principle,
> at least, that's the only variable that couldn't be reproduced by
> someone else.

OK, we can put it in src/tools/pgindent, I guess.

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andrew Dunstan on


Bruce Momjian wrote:



>> I have a TODO on fixing some of the typedef finding. But I can generate
>> an up to date version of the list Bruce last used in a day or two, and
>> then get this better whacked into shape for another run at the more
>> traditional time.
>>
>
> I am ready to run pgindent whenever requested.
>
>

There is an updated typedefs list at
<http://www.pgbuildfarm.org/cgi-bin/typedefs.pl>

cheers

andrew



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Thu, Feb 18, 2010 at 11:51 PM, Andrew Dunstan <andrew(a)dunslane.net> wrote:
> Bruce Momjian wrote:
>>> I have a TODO on fixing some of the typedef finding. But I can generate
>>> an up to date version of the list Bruce last used in a day or two, and then
>>> get this better whacked into shape for another run at the more traditional
>>> time.
>>
>> I am ready to run pgindent whenever requested.
> There is an updated typedefs list at
> <http://www.pgbuildfarm.org/cgi-bin/typedefs.pl>

Bruce, you want to go ahead and do this? The sooner the better, AFAICS.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Bruce Momjian on
Robert Haas wrote:
> On Thu, Feb 18, 2010 at 11:51 PM, Andrew Dunstan <andrew(a)dunslane.net> wrote:
> > Bruce Momjian wrote:
> >>> I have a TODO on fixing some of the typedef finding. But I can generate
> >>> an up to date version of the list Bruce last used in a day or two, and then
> >>> get this better whacked into shape for another run at the more traditional
> >>> time.
> >>
> >> I am ready to run pgindent whenever requested.
> > There is an updated typedefs list at
> > <http://www.pgbuildfarm.org/cgi-bin/typedefs.pl>
>
> Bruce, you want to go ahead and do this? The sooner the better, AFAICS.

I am ready.

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers