Prev: Streaming replication and unfit messages
Next: [HACKERS] SR: "pseudo replication database of the primary" ...
From: Robert Haas on 25 Feb 2010 22:10
On Thu, Feb 25, 2010 at 9:03 PM, Bruce Momjian <bruce(a)momjian.us> wrote:
> Done.  The diff is here:
>
>        http://momjian.us/tmp/pgindent.diff
>
> and I checked into CVS a copy of the typedef list I used from Andrew
> Dunstan.

Cool, thanks. Let the rebasing (if any) begin.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Greg Smith on 26 Feb 2010 03:54
Bruce Momjian wrote:
> The diff is here:
>
> http://momjian.us/tmp/pgindent.diff
>
> and I checked into CVS a copy of the typedef list I used from Andrew
> Dunstan.
>

Is it worthwhile to consider writing up a "how to run pgindent like
Bruce does" page on the wiki? I've been scared off of that topic before
because it always seemed like it was perilous and there were missing
pieces. I think we'd get some uptake from contributors doing this
themselves before submitting patches if it were made easy enough for
them to do. I know I'd do it just to get rid of the accidental
tab/space errors that always manage to sneak into non-trivial work, if I
could automate the whole thing as a pass to do just before generating a
final diff to submit.

--
Greg Smith 2ndQuadrant US Baltimore, MD
PostgreSQL Training, Services and Support
greg(a)2ndQuadrant.com www.2ndQuadrant.us


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Bruce Momjian on 26 Feb 2010 08:29
Greg Smith wrote:
> Bruce Momjian wrote:
> > The diff is here:
> >
> > http://momjian.us/tmp/pgindent.diff
> >
> > and I checked into CVS a copy of the typedef list I used from Andrew
> > Dunstan.
> >
>
> Is it worthwhile to consider writing up a "how to run pgindent like
> Bruce does" page on the wiki? I've been scared off of that topic before
> because it always seemed like it was perilous and there were missing
> pieces. I think we'd get some uptake from contributors doing this
> themselves before submitting patches if it were made easy enough for
> them to do. I know I'd do it just to get rid of the accidental
> tab/space errors that always manage to sneak into non-trivial work, if I
> could automate the whole thing as a pass to do just before generating a
> final diff to submit.

Have you read the README in src/tools/pgindent?

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2 3 4 5
Prev: Streaming replication and unfit messages
Next: [HACKERS] SR: "pseudo replication database of the primary" ...