Command to prune archive at restartpoints
in [PgSql]
|
From: Takahiro Itagaki on 8 Jun 2010 21:45 Robert Haas <robertmhaas(a)gmail.com> wrote: > On Tue, Jun 8, 2010 at 6:45 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > > Andrew Dunstan <andrew(a)dunslane.net> writes: > >> I prefer archive_cleanup_command. We should name things after their > >> principal function, not an implementation detail, IMNSHO. > > > > Weak preference for archive_cleanup_command here. > > OK, sounds like we have consensus on that. Who wants to do it? Do we just need to replace all of them? If so, patch attached. I replaced 3 terms: recovery_end_command, recovery-end-command, and recoveryEndCommand. Regards, --- Takahiro Itagaki NTT Open Source Software Center
From: Simon Riggs on 9 Jun 2010 03:19 On Wed, 2010-06-09 at 11:18 +0900, Takahiro Itagaki wrote: > Robert Haas <robertmhaas(a)gmail.com> wrote: > > I think we're replacing restartpoint_command, not recovery_end_command. > > Ah, sorry. I did the same replacement for restartpoint_command > in _, -, and camel case words. > > BTW, should we also have a release note for the command? > I added a simple description for it in the patch. I don't think so, its not a separate feature. It's a change as part of SR. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 9 Jun 2010 03:21 On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote: > I prefer archive_cleanup_command. We should name things after their > principal function, not an implementation detail, IMNSHO. > > More importantly, we should include an example in the docs. I created > one the other day when this was actually bothering me a bit (see > <http://people.planetpostgresql.org/andrew/index.php?/archives/85-Keeping-a-hot-standby-log-archive-clean.html>). > That seemed to work ok, but maybe it's too long, and maybe people would > prefer a shell script to perl. I submitted a patch to make the command "pg_standby -a %r" That's a more portable solution, ISTM. I'll commit that and fix the docs. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Heikki Linnakangas on 10 Jun 2010 03:18 On 09/06/10 10:21, Simon Riggs wrote: > On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote: > >> I prefer archive_cleanup_command. We should name things after their >> principal function, not an implementation detail, IMNSHO. >> >> More importantly, we should include an example in the docs. I created >> one the other day when this was actually bothering me a bit (see >> <http://people.planetpostgresql.org/andrew/index.php?/archives/85-Keeping-a-hot-standby-log-archive-clean.html>). >> That seemed to work ok, but maybe it's too long, and maybe people would >> prefer a shell script to perl. > > I submitted a patch to make the command "pg_standby -a %r" > > That's a more portable solution, ISTM. > > I'll commit that and fix the docs. Huh, wait. There's no -a option in pg_standby, so I presume you're planning to add that too. I don't like confusing pg_standby into this, the docs are currently quite clear that if you want to use the built-in standby mode, you can't use pg_standby, and this would muddy the waters. Maybe we could add a new pg_cleanuparchive binary, but we'll need some discussion... -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 10 Jun 2010 03:28
On Thu, 2010-06-10 at 10:18 +0300, Heikki Linnakangas wrote: > On 09/06/10 10:21, Simon Riggs wrote: > > On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote: > > > >> I prefer archive_cleanup_command. We should name things after their > >> principal function, not an implementation detail, IMNSHO. > >> > >> More importantly, we should include an example in the docs. I created > >> one the other day when this was actually bothering me a bit (see > >> <http://people.planetpostgresql.org/andrew/index.php?/archives/85-Keeping-a-hot-standby-log-archive-clean.html>). > >> That seemed to work ok, but maybe it's too long, and maybe people would > >> prefer a shell script to perl. > > > > I submitted a patch to make the command "pg_standby -a %r" > > > > That's a more portable solution, ISTM. > > > > I'll commit that and fix the docs. > > Huh, wait. There's no -a option in pg_standby, so I presume you're > planning to add that too. I don't like confusing pg_standby into this, > the docs are currently quite clear that if you want to use the built-in > standby mode, you can't use pg_standby, and this would muddy the waters. It won't kill us to change that sentence. "pg_standby is only used now within the cleanup command" etc pg_standby already contains the exact logic we need here. Having two sets of code for the same thing isn't how we do things. > Maybe we could add a new pg_cleanuparchive binary, but we'll need some > discussion... Which will go nowhere, as we both already know. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |