Command to prune archive at restartpoints
in [PgSql]
|
From: Simon Riggs on 8 Jun 2010 17:32 On Tue, 2010-06-08 at 17:17 -0400, Robert Haas wrote: > On Mon, Mar 22, 2010 at 11:58 AM, Greg Stark <gsstark(a)mit.edu> wrote: > > On Thu, Mar 18, 2010 at 9:43 AM, Simon Riggs <simon(a)2ndquadrant.com> wrote: > >> On Wed, 2010-03-17 at 11:37 +0200, Heikki Linnakangas wrote: > >> > >>> One awkward omission in the new built-in standby mode, mainly used for > >>> streaming replication, is that there is no easy way to delete old > >>> archived files like you do with the %r parameter to restore_command. > >> > >> Would it be better to call this "archive_cleanup_command"? That might > >> help people understand the need for and the use of this parameter. > > > > This is bikeshedding but fwiw I like Simon's suggestion. > > So, this thread is hanging out on our list of open items for 9.0. My > personal opinion on it is that I don't really care much one way or the > other. archive_cleanup_command does seem easier to understand, but > restartpoint_command has the advantage of describing exactly when it > gets run from a technical perspective, which might be a good thing, > too. Since nobody's felt motivated to do anything about this for two > and a half months and we've now been through two betas with it the way > it is, I'm inclined to say we should just leave it alone. On the > other hand, both of the people who voted in favor of changing it are > committers, and if one of them feels like putting in the effort to > change it, it won't bother me much, except that I feel it should get > done RSN. But one way or the other we need to make a decision and get > this off the list. Yes, restartpoint_command is exactly correct, and I do understand it; I just don't think anyone else will. If there's another use for a restartpoint_command other than for clearing up an archive, then it would be sufficient to destroy the name change idea. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 8 Jun 2010 18:30 Robert Haas wrote: > On Mon, Mar 22, 2010 at 11:58 AM, Greg Stark <gsstark(a)mit.edu> wrote: > >> On Thu, Mar 18, 2010 at 9:43 AM, Simon Riggs <simon(a)2ndquadrant.com> wrote: >> >>> On Wed, 2010-03-17 at 11:37 +0200, Heikki Linnakangas wrote: >>> >>> >>>> One awkward omission in the new built-in standby mode, mainly used for >>>> streaming replication, is that there is no easy way to delete old >>>> archived files like you do with the %r parameter to restore_command. >>>> >>> Would it be better to call this "archive_cleanup_command"? That might >>> help people understand the need for and the use of this parameter. >>> >> This is bikeshedding but fwiw I like Simon's suggestion. >> > > So, this thread is hanging out on our list of open items for 9.0. My > personal opinion on it is that I don't really care much one way or the > other. archive_cleanup_command does seem easier to understand, but > restartpoint_command has the advantage of describing exactly when it > gets run from a technical perspective, which might be a good thing, > too. Since nobody's felt motivated to do anything about this for two > and a half months and we've now been through two betas with it the way > it is, I'm inclined to say we should just leave it alone. On the > other hand, both of the people who voted in favor of changing it are > committers, and if one of them feels like putting in the effort to > change it, it won't bother me much, except that I feel it should get > done RSN. But one way or the other we need to make a decision and get > this off the list. > > I prefer archive_cleanup_command. We should name things after their principal function, not an implementation detail, IMNSHO. More importantly, we should include an example in the docs. I created one the other day when this was actually bothering me a bit (see <http://people.planetpostgresql.org/andrew/index.php?/archives/85-Keeping-a-hot-standby-log-archive-clean.html>). That seemed to work ok, but maybe it's too long, and maybe people would prefer a shell script to perl. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 8 Jun 2010 19:07 Tom Lane wrote: > As for the language choice, my first thought is +1 for perl over shell, > mainly because it might be directly useful to people on Windows while > shell never would be. On the other hand, if it's possible to do a > useful one-liner in shell then let's do it that way. > I don't think it is, reasonably. But here is fairly minimal version that might suit the docs: use strict; my ($dir, $num) = @ARGV; foreach my $file (glob("$dir/*")) { my $name = basename($file); unlink $file if (-f $file && $name =~ /^[0-9A-Z]{24}$/ && $name lt $num); } cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Takahiro Itagaki on 8 Jun 2010 22:18 Robert Haas <robertmhaas(a)gmail.com> wrote: > I think we're replacing restartpoint_command, not recovery_end_command. Ah, sorry. I did the same replacement for restartpoint_command in _, -, and camel case words. BTW, should we also have a release note for the command? I added a simple description for it in the patch. Regards, --- Takahiro Itagaki NTT Open Source Software Center
From: Robert Haas on 8 Jun 2010 22:58 On Tue, Jun 8, 2010 at 10:18 PM, Takahiro Itagaki <itagaki.takahiro(a)oss.ntt.co.jp> wrote: > > Robert Haas <robertmhaas(a)gmail.com> wrote: >> I think we're replacing restartpoint_command, not recovery_end_command. > > Ah, sorry. I did the same replacement for restartpoint_command > in _, -, and camel case words. Gah. Perhaps one of these days we will stop spelling every identifier in multiple different ways. > BTW, should we also have a release note for the command? > I added a simple description for it in the patch. Yeah, it should be definitely mentioned in the release notes somewhere, I think. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Next
|
Last
Pages: 1 2 3 4 5 6 7 Prev: How about closing some Open Items? Next: [HACKERS] LLVM / clang |