CommitFest 2009-09, two weeks on
in [PgSql]
|
From: Tom Lane on 30 Sep 2009 12:27 Joe Conway <mail(a)joeconway.com> writes: > Robert Haas wrote: >> - There is one dblink pach left over from last CommitFest. Joe Conway >> was going to review it the weekend of July 18th-19th, but that didn't >> end up happening and so that patch is still waiting. We might be able >> to find someone else to review it, but I'm not sure whether that will >> help unless there is a committer other than Joe with bandwidth to do >> the final review and commit. > I will get to it before the end of this commitfest, but I have to admit > I'm not all that excited about this patch in the first place. I don't > know that I agree with the need. Well, you're the dblink expert. If you think it should be rejected I doubt many of us will argue with you. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 30 Sep 2009 12:34 Robert Haas <robertmhaas(a)gmail.com> writes: > ... (and many of the more > significant remaining patches look like they are right up Tom's alley > anyway). FWIW, if left to my own devices I will eventually get to everything except the dblink, ecpg, and encoding/win32 patches. I don't intend to touch any of those because there are other committers better qualified to review them. (I don't actually think we have anybody except Michael who's really familiar with ecpg.) However, if no other committers are working on it it's going to be a long commitfest ... The other problem is that most of the patches are not Ready for Committer anyway. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 30 Sep 2009 12:51 On Wed, Sep 30, 2009 at 12:27 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > Joe Conway <mail(a)joeconway.com> writes: >> Robert Haas wrote: >>> - There is one dblink pach left over from last CommitFest. Joe Conway >>> was going to review it the weekend of July 18th-19th, but that didn't >>> end up happening and so that patch is still waiting. We might be able >>> to find someone else to review it, but I'm not sure whether that will >>> help unless there is a committer other than Joe with bandwidth to do >>> the final review and commit. > >> I will get to it before the end of this commitfest, but I have to admit >> I'm not all that excited about this patch in the first place. I don't >> know that I agree with the need. > > Well, you're the dblink expert. If you think it should be rejected > I doubt many of us will argue with you. Yep. CommitFest doesn't mean "commit it"; it means "decide whether to commit it". Things being rejected or returned with feedback for further improvement is fine; we're just trying to avoid long periods with no response at all. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 30 Sep 2009 13:01 On Wed, Sep 30, 2009 at 12:34 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas(a)gmail.com> writes: >> ... (and many of the more >> significant remaining patches look like they are right up Tom's alley >> anyway). > > FWIW, if left to my own devices I will eventually get to everything > except the dblink, ecpg, and encoding/win32 patches. I don't intend > to touch any of those because there are other committers better > qualified to review them. (I don't actually think we have anybody > except Michael who's really familiar with ecpg.) Thanks, I think that's helpful information. > However, if no other committers are working on it it's going to be > a long commitfest ... That is my concern as well. > The other problem is that most of the patches are not Ready for > Committer anyway. I (and hopefully the people who agreed to help with patch-chasing) can work on this, but given that there are 5 that are Ready for Committer and probably as many more that are close, and further given that in the past 7 days exactly 1 patch from the CommitFest has been committed, I'm not sure there's a real problem here. If you commit/bounce all 5 of those afternoon I will spend the evening making sure you have a few more to tackle tomorrow. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 30 Sep 2009 13:26
Robert Haas wrote: > On Wed, Sep 30, 2009 at 12:34 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > >> Robert Haas <robertmhaas(a)gmail.com> writes: >> >>> ... (and many of the more >>> significant remaining patches look like they are right up Tom's alley >>> anyway). >>> >> FWIW, if left to my own devices I will eventually get to everything >> except the dblink, ecpg, and encoding/win32 patches. I don't intend >> to touch any of those because there are other committers better >> qualified to review them. (I don't actually think we have anybody >> except Michael who's really familiar with ecpg.) >> > > Thanks, I think that's helpful information. > > >> However, if no other committers are working on it it's going to be >> a long commitfest ... >> > > That is my concern as well. > > I have been (and still am somewhat) slammed, but I can probably make space to work on "Encoding issues in console and eventlog on win32 <https://commitfest.postgresql.org/action/patch_view?id=148>" some time in the next day or three. After that, if I still have time and nobody else has grabbed it, I'll move on to "CREATE LIKE INCLUDING COMMENTS and STORAGE <https://commitfest.postgresql.org/action/patch_view?id=172>". cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |