CommitFest 2009-09, two weeks on
in [PgSql]
|
From: =?iso-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= on 13 Nov 2009 03:52 On Nov 13, 2009, at 8:06 AM, Michael Meskes wrote: > On Thu, Nov 12, 2009 at 03:07:27PM -0500, Robert Haas wrote: >>> If you want to submit patches in a series like this one, they need >>> to be >>> considered standalone, I think. The Linux kernel devs work >>> differently >>> than us here. >> >> Zoltan broke them up because Michael asked him to do so. > > Actually these patchsets add different features. I see no reason why > they > should be done as one patch. However, I haven't had the time to look > into the > latest ones, but at least that was the situation when I asked Zoltan > to split > the patch. > > Michael > -- > Michael Meskes > Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) > Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org > ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(a)jabber.org > VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, > PostgreSQL > good morning, are there some pending technical issues with those patches or can we basically review and commit? many thanks, hans -- Cybertec Schönig & Schönig GmbH Reyergasse 9 / 2 A-2700 Wiener Neustadt Web: www.postgresql-support.de -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 13 Nov 2009 07:14 2009/11/13 Hans-Jürgen Schönig <hs(a)cybertec.at>: > > On Nov 13, 2009, at 8:06 AM, Michael Meskes wrote: > >> On Thu, Nov 12, 2009 at 03:07:27PM -0500, Robert Haas wrote: >>>> >>>> If you want to submit patches in a series like this one, they need to be >>>> considered standalone, I think. The Linux kernel devs work differently >>>> than us here. >>> >>> Zoltan broke them up because Michael asked him to do so. >> >> Actually these patchsets add different features. I see no reason why they >> should be done as one patch. However, I haven't had the time to look into >> the >> latest ones, but at least that was the situation when I asked Zoltan to >> split >> the patch. >> >> Michael >> -- >> Michael Meskes >> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) >> Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org >> ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(a)jabber.org >> VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL >> > > > > good morning, > > are there some pending technical issues with those patches or can we > basically review and commit? *scratches head* How is anyone supposed to answer that question? It is in the process of reviewing them that one decides whether there are any technical issues... ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Boszormenyi Zoltan on 13 Nov 2009 08:35
Alvaro Herrera �rta: > Boszormenyi Zoltan escribi�: > >> Alvaro Herrera �rta: >> >>> I have applied this patch after some tinkering. I mainly added support >>> for "fetch_args: FORWARD opt_from_in name" and "BACKWARD opt_from_in >>> name" in ecpg.addons which apparently you forgot. >>> >> Thanks. Your fix is correct if this patch is considered >> standalone. This means I have to re-post the later >> patches to fix the reject this fix causes in them. >> > > Yeah. BTW I don't think the rest of the pieces in this series make > sense to apply separately, because they don't do anything useful by > themselves (one of them introduces an unused function, what good is in > that?). I think they should be submitted as a single patch. > > If you want to submit patches in a series like this one, they need to be > considered standalone, I think. The Linux kernel devs work differently > than us here. > Dan started reviewing the dynamic cursorname patch. He looked at it in the original form and he said that he's not familiar with the ECPG code. I have drafted the docs for the generated ECPG grammar (it was applied mainstream by Michael shortly after being posted) and have split this patch in question to help Dan in the review. The patch pieces explain the various problems about the implementation. Is it really *that* apparent that I read too much LKML? :-D -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zolt�n B�sz�rm�nyi Cybertec Sch�nig & Sch�nig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |