ECPG check variables hidden by locals v2
in [PgSql]
|
Prev: [HACKERS] non-reproducible failure of random test on HEAD
Next: [HACKERS] Naming of new EXCLUDE constraints
From: Bruce Momjian on 12 Apr 2010 20:10 FYI, I think Michael Meskes applied this patch, though I didn't see you emailed that it was applied. --------------------------------------------------------------------------- Boszormenyi Zoltan wrote: > Hi, > > here's a little beautified patch: > - more logical parameter order in ECPGdump_a_type() > - use mm_strdup() instead of strdup() (I notoriously forget this) > - actually bail out with ET_FATAL if the local variable is > of a different type than the global variable that was used in > the DECLARE in the global scope > > Although with this patch we can only detect variables under > DECLARE SECTIONs, so we can't detect the scenario > in the attached test case. Should we? This test code would be > a good candidate for the Underhanded C Contest. :-) > > Best regards, > Zolt?n B?sz?rm?nyi > > -- > Bible has answers for everything. Proof: > "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more > than these cometh of evil." (Matthew 5:37) - basics of digital technology. > "May your kingdom come" - superficial description of plate tectonics > > ---------------------------------- > Zolt?n B?sz?rm?nyi > Cybertec Sch?nig & Sch?nig GmbH > http://www.postgresql.at/ > [ Attachment, skipping... ] [ Attachment, skipping... ] > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Boszormenyi Zoltan on 13 Apr 2010 00:39
Yes, he applied the first version without seeing this one, then he asked for a re-diff privately. Bruce Momjian �rta: > FYI, I think Michael Meskes applied this patch, though I didn't see you > emailed that it was applied. > > --------------------------------------------------------------------------- > > Boszormenyi Zoltan wrote: > >> Hi, >> >> here's a little beautified patch: >> - more logical parameter order in ECPGdump_a_type() >> - use mm_strdup() instead of strdup() (I notoriously forget this) >> - actually bail out with ET_FATAL if the local variable is >> of a different type than the global variable that was used in >> the DECLARE in the global scope >> >> Although with this patch we can only detect variables under >> DECLARE SECTIONs, so we can't detect the scenario >> in the attached test case. Should we? This test code would be >> a good candidate for the Underhanded C Contest. :-) >> >> Best regards, >> Zolt?n B?sz?rm?nyi >> >> -- >> Bible has answers for everything. Proof: >> "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more >> than these cometh of evil." (Matthew 5:37) - basics of digital technology. >> "May your kingdom come" - superficial description of plate tectonics >> >> ---------------------------------- >> Zolt?n B?sz?rm?nyi >> Cybertec Sch?nig & Sch?nig GmbH >> http://www.postgresql.at/ >> >> > > [ Attachment, skipping... ] > > [ Attachment, skipping... ] > > >> -- >> Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgsql-hackers >> > > -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zolt�n B�sz�rm�nyi Cybertec Sch�nig & Sch�nig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |