Prev: [patch] add quirk to fix volume wheel on Toshiba U300 laptops
Next: [tip:perf/core] x86: Unify save_stack_address() and save_stack_address_nosched()
From: Linus Torvalds on 11 Jun 2010 13:50
On Fri, Jun 11, 2010 at 10:17 AM, Salman <sqazi(a)google.com> wrote:
> Fixed the whitespace issue that Michel pointed out.
>
> Btw., who is responsible for ACKing this?

I don't know about "responsible", but I'll Ack it. Much of that code
is really old. And exactly since this is a really old issue, I think
I'll leave it unapplied for now, and let it simmer in some test-queue
(get it into next somehow?) until I get back.

Also, now that I look at that complex end-condition for the while-loop
and the big comment, I do start to think that Ingo was right, and it
would be better to make that thing a helper function of its own,
called something like "set_last_pid(pid_ns, last, pid);"

That would lessen the indentation a lot too, and with the commentary,
it would all look fairly pretty.

So Ack-with-cleanup-suggestion. And maybe Andrew can take it into -mm
while I'm gone? Or Ingo into some core-branch? You fight it out, but I
think this is already acceptable, just perhaps still open to
improvement.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 11 Jun 2010 19:10
Yup. Much prettier. Thanks.

Ingo, Andrew, you can now have a cage-match on who actually takes it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: [patch] add quirk to fix volume wheel on Toshiba U300 laptops
Next: [tip:perf/core] x86: Unify save_stack_address() and save_stack_address_nosched()