[PATCH 09/12] osst: Use noop_llseek() instead of default_llseek()
in [Kernel]
|
Prev: [PATCH 02/12] flash_read should update ppos instead of file->f_pos
Next: [PATCH 10/12] st: Use noop_llseek() instead of default_llseek()
From: Jan Blunck on 9 Apr 2010 10:10 __os_scsi_tape_open() suggests that llseek() doesn't work: "We really want to do nonseekable_open(inode, filp); here, but some versions of tar incorrectly call lseek on tapes and bail out if that fails. So we disallow pread() and pwrite(), but permit lseeks." Instead of using the fallback default_llseek() the driver should use noop_llseek() which leaves the file->f_pos untouched but succeeds. Signed-off-by: Jan Blunck <jblunck(a)suse.de> --- drivers/scsi/osst.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 9dc0b9a..960e39c 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -5619,6 +5619,7 @@ static const struct file_operations osst_fops = { .open = os_scsi_tape_open, .flush = os_scsi_tape_flush, .release = os_scsi_tape_close, + .llseek = noop_llseek, }; static int osst_supports(struct scsi_device * SDp) -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |