Prev: [PATCH 09/12] osst: Use noop_llseek() instead of default_llseek()
Next: [PATCH 08/12] Introduce noop_llseek()
From: Jan Blunck on 9 Apr 2010 10:10
st_open() suggests that llseek() doesn't work:
"We really want to do nonseekable_open(inode, filp); here, but some
versions of tar incorrectly call lseek on tapes and bail out if that
fails. So we disallow pread() and pwrite(), but permit lseeks."

Instead of using the fallback default_llseek() the driver should use
noop_llseek() which leaves the file->f_pos untouched but succeeds.

Signed-off-by: Jan Blunck <jblunck(a)suse.de>
---
drivers/scsi/st.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index f67d1a1..78e8f42 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -3961,6 +3961,7 @@ static const struct file_operations st_fops =
.open = st_open,
.flush = st_flush,
.release = st_release,
+ .llseek = noop_llseek,
};

static int st_probe(struct device *dev)
--
1.6.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 09/12] osst: Use noop_llseek() instead of default_llseek()
Next: [PATCH 08/12] Introduce noop_llseek()