Prev: [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance
Next: Poor interactive performance with I/O loads with fsync()ing
From: Jiri Slaby on 16 Mar 2010 11:40
Stanse found that one error path in netpoll_setup dereferences npinfo
even though it is NULL. Avoid that by adding new label and go to that
instead.

Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
Cc: Daniel Borkmann <danborkmann(a)googlemail.com>
Cc: David S. Miller <davem(a)davemloft.net>
---
net/core/netpoll.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7aa6972..d4ec38f 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -735,7 +735,7 @@ int netpoll_setup(struct netpoll *np)
npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);
if (!npinfo) {
err = -ENOMEM;
- goto release;
+ goto put;
}

npinfo->rx_flags = 0;
@@ -845,7 +845,7 @@ int netpoll_setup(struct netpoll *np)

kfree(npinfo);
}
-
+put:
dev_put(ndev);
return err;
}
--
1.7.0.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance
Next: Poor interactive performance with I/O loads with fsync()ing