[PATCH 3/3] SCSI: qla2xxx, fix lock imbalance
in [Kernel]
|
Prev: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance
Next: [PATCH 1/1] NET: netpoll, fix potential NULL ptr dereference
From: Jiri Slaby on 16 Mar 2010 11:30 Stanse found that one error path in qla24xx_bsg_timeout omits to unlock ha->hardware_lock. Fix that. Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> Cc: Giridhar Malavali <giridhar.malavali(a)qlogic.com> Cc: James Bottomley <James.Bottomley(a)suse.de> --- drivers/scsi/qla2xxx/qla_attr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 90d1e06..a3591e5 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -2388,6 +2388,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job) return 0; done: + spin_unlock_irqrestore(&ha->hardware_lock, flags); if (bsg_job->request->msgcode == FC_BSG_HST_CT) kfree(sp->fcport); kfree(sp->ctx); -- 1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Giridhar Malavali on 16 Mar 2010 16:30
On 3/16/10 8:23 AM, "Jiri Slaby" <jslaby(a)suse.cz> wrote: > Stanse found that one error path in qla24xx_bsg_timeout omits to > unlock ha->hardware_lock. Fix that. > > Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> > Cc: Giridhar Malavali <giridhar.malavali(a)qlogic.com> > Cc: James Bottomley <James.Bottomley(a)suse.de> > --- > drivers/scsi/qla2xxx/qla_attr.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c > index 90d1e06..a3591e5 100644 > --- a/drivers/scsi/qla2xxx/qla_attr.c > +++ b/drivers/scsi/qla2xxx/qla_attr.c > @@ -2388,6 +2388,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job) > return 0; > > done: > + spin_unlock_irqrestore(&ha->hardware_lock, flags); > if (bsg_job->request->msgcode == FC_BSG_HST_CT) > kfree(sp->fcport); > kfree(sp->ctx); > -- > 1.7.0.1 > > Acked-by: Giridhar Malavali <giridhar.malavali(a)qlogic.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |