[PATCH 1/7] edac: mpc85xx fix bad page calculation
in [Kernel]
|
Prev: irda: unbalanced lock_kernel in irnet_ppp
Next: [PATCH 5/7] edac: mpc85xx use resource_size instead of raw math
From: dougthompson on 4 Feb 2010 01:50 From: Peter Tyser <ptyser(a)xes-inc.com> Commit b4846251727a38a7f248e41308c060995371dd05 accidentally broke how a chip select's first and last page addresses are calculated. The page addresses are being shifted too far right by PAGE_SHIFT. This results in errors such as: EDAC MPC85xx MC1: Err addr: 0x003075c0 EDAC MPC85xx MC1: PFN: 0x00000307 EDAC MPC85xx MC1: PFN out of range! EDAC MC1: INTERNAL ERROR: row out of range (4 >= 4) EDAC MC1: CE - no information available: INTERNAL ERROR The vale of PAGE_SHIFT is already being taken into consideration during the calculation of the 'start' and 'end' variables, thus it is not necessary to account for it again when setting a chip select's first and last page address. Signed-off-by: Peter Tyser <ptyser(a)xes-inc.com> Signed-off-by: Doug Thompson <dougthompson(a)xmission.com> --- drivers/edac/mpc85xx_edac.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.33-rc4/drivers/edac/mpc85xx_edac.c =================================================================== --- linux-2.6.33-rc4.orig/drivers/edac/mpc85xx_edac.c 2010-01-13 00:15:58.000000000 -0700 +++ linux-2.6.33-rc4/drivers/edac/mpc85xx_edac.c 2010-01-13 00:16:00.000000000 -0700 @@ -804,8 +804,8 @@ static void __devinit mpc85xx_init_csrow end <<= (24 - PAGE_SHIFT); end |= (1 << (24 - PAGE_SHIFT)) - 1; - csrow->first_page = start >> PAGE_SHIFT; - csrow->last_page = end >> PAGE_SHIFT; + csrow->first_page = start; + csrow->last_page = end; csrow->nr_pages = end + 1 - start; csrow->grain = 8; csrow->mtype = mtype; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |