Prev: [PATCH 1/7] edac: mpc85xx fix bad page calculation
Next: syslog: distinguish between /proc/kmsg and syscalls
From: dougthompson on 4 Feb 2010 01:50 From: H Hartley Sweeten <hsweeten(a)visionengravers.com> Use resource_size() instead of arithmatic. Signed-off-by: H Hartley Sweeten <hsweeten(a)visionengravers.com> Signed-off-by: Doug Thompson <dougthompson(a)xmission.com> Acked-by: Dave Jiang <djiang(a)mvista.com> --- mpc85xx_edac.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) Index: linux-2.6.33-rc4/drivers/edac/mpc85xx_edac.c =================================================================== --- linux-2.6.33-rc4.orig/drivers/edac/mpc85xx_edac.c 2010-01-13 00:18:21.000000000 -0700 +++ linux-2.6.33-rc4/drivers/edac/mpc85xx_edac.c 2010-01-13 00:18:23.000000000 -0700 @@ -239,16 +239,15 @@ static int __devinit mpc85xx_pci_err_pro /* we only need the error registers */ r.start += 0xe00; - if (!devm_request_mem_region(&op->dev, r.start, - r.end - r.start + 1, pdata->name)) { + if (!devm_request_mem_region(&op->dev, r.start, resource_size(&r), + pdata->name)) { printk(KERN_ERR "%s: Error while requesting mem region\n", __func__); res = -EBUSY; goto err; } - pdata->pci_vbase = devm_ioremap(&op->dev, r.start, - r.end - r.start + 1); + pdata->pci_vbase = devm_ioremap(&op->dev, r.start, resource_size(&r)); if (!pdata->pci_vbase) { printk(KERN_ERR "%s: Unable to setup PCI err regs\n", __func__); res = -ENOMEM; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |