Prev: Staging: comedi: fix EXPORT_SYMBOL(FOO) coding style issues in ni_labpc.c
Next: uml: Fix warning due to missing task_struct declaration
From: Jeff Dike on 20 Apr 2010 13:00
On Tue, Apr 20, 2010 at 04:35:52PM +0200, Jiri Kosina wrote:
> On Tue, 20 Apr 2010, Amerigo Wang wrote:
> > Shouldn't this signal.c #include <linux/kernel.h>?
>
> Well, it gets included implicitly through uaccess.h -> sched.h ->
> kernel.h.

You're depending on the internal details of uaccess.h and sched.h. If
either of them changed, then this would cause unexpected compile
failures here.

Better to explicitly include kernel.h.

Jeff

--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Staging: comedi: fix EXPORT_SYMBOL(FOO) coding style issues in ni_labpc.c
Next: uml: Fix warning due to missing task_struct declaration