Prev: trace-cmd: make Makefile rpm-friendly
Next: [PATCH 2/5] uml: Drop private round_down definition
From: Greg KH on 19 Apr 2010 13:20
On Mon, Apr 19, 2010 at 05:49:08PM +0100, Maurice Dawson wrote:
> This is a re-submitted patch to the ni_labpc.c file that fixes EXPORT_SYMBOL(FOO) warnings found by the checkpatch.pl tool
>
> Signed-off-by: Maurice Dawson <mauricedawson2699(a)googlemail.com>
> ---
> drivers/staging/comedi/drivers/ni_labpc.c | 31 +++++++++++++++--------------
> 1 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index becbe47..26e02d9 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -314,7 +314,6 @@ const int labpc_1200_is_unipolar[NUM_LABPC_1200_AI_RANGES] = {
> 1,
> 1,
> };
> -
> /* map range index to gain bits */
> const int labpc_1200_ai_gain_bits[NUM_LABPC_1200_AI_RANGES] = {
> 0x00,

Why remove this line? Did that change any warning?

You also do that for a lot of other lines in this file, which isn't
good.

How about only fixing the warnings, and not mushing other lines up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: trace-cmd: make Makefile rpm-friendly
Next: [PATCH 2/5] uml: Drop private round_down definition