[PATCH 21/29] move sgivwfb's probe function to .devinit.text
in [Kernel]
|
Prev: [PATCH 01/29] move acornfb's probe function to .devinit.text
Next: [PATCH 24/29] move sh_mobile_lcdc_fb's probe function to .devinit.text
From: Uwe Kleine-König on 23 Jan 2010 15:50 A pointer to sgivwfb_probe is passed to the core via platform_driver_register and so the function must not disappear when the ..init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> Cc: Antonino Daplas <adaplas(a)gmail.com> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Adrian Bunk <bunk(a)stusta.de> Cc: Christoph Hellwig <hch(a)lst.de> --- drivers/video/sgivwfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/sgivwfb.c b/drivers/video/sgivwfb.c index f860122..7a3a5e2 100644 --- a/drivers/video/sgivwfb.c +++ b/drivers/video/sgivwfb.c @@ -745,7 +745,7 @@ int __init sgivwfb_setup(char *options) /* * Initialisation */ -static int __init sgivwfb_probe(struct platform_device *dev) +static int __devinit sgivwfb_probe(struct platform_device *dev) { struct sgivw_par *par; struct fb_info *info; -- 1.6.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |