[PATCH 24/29] move sh_mobile_lcdc_fb's probe function to .devinit.text
in [Kernel]
|
Prev: [PATCH 21/29] move sgivwfb's probe function to .devinit.text
Next: [PATCH 28/29] move vga16fb's probe function to .devinit.text
From: Uwe Kleine-König on 23 Jan 2010 15:50 A pointer to sh_mobile_lcdc_probe is passed to the core via platform_driver_register and so the function must not disappear when the ..init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> Cc: Greg Kroah-Hartman <gregkh(a)suse.de> Cc: Magnus Damm <damm(a)igel.co.jp> Cc: Paul Mundt <lethal(a)linux-sh.org> Cc: Krzysztof Helt <krzysztof.h1(a)poczta.fm> Cc: Andrew Morton <akpm(a)linux-foundation.org> --- drivers/video/sh_mobile_lcdcfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c index a69830d..8f3c786 100644 --- a/drivers/video/sh_mobile_lcdcfb.c +++ b/drivers/video/sh_mobile_lcdcfb.c @@ -907,7 +907,7 @@ static const struct dev_pm_ops sh_mobile_lcdc_dev_pm_ops = { static int sh_mobile_lcdc_remove(struct platform_device *pdev); -static int __init sh_mobile_lcdc_probe(struct platform_device *pdev) +static int __devinit sh_mobile_lcdc_probe(struct platform_device *pdev) { struct fb_info *info; struct sh_mobile_lcdc_priv *priv; -- 1.6.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |