Prev: readahead: fix NULL filp dereference
Next: [PATCH 1/3] arch/powerpc/platforms: Eliminate use after free
From: Julia Lawall on 2 Apr 2010 08:50
From: Julia Lawall <julia(a)diku.dk>

Use the call to snd_card_free in the error handling code at the end of the
function, as in the other error cases.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E,E2;
@@

snd_card_free(E)
....
(
E = E2
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
sound/pci/echoaudio/echoaudio.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index 8dab82d..668a5ec 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2184,10 +2184,9 @@ static int __devinit snd_echo_probe(struct pci_dev *pci,
goto ctl_error;
#endif

- if ((err = snd_card_register(card)) < 0) {
- snd_card_free(card);
+ err = snd_card_register(card);
+ if (err < 0)
goto ctl_error;
- }
snd_printk(KERN_INFO "Card registered: %s\n", card->longname);

pci_set_drvdata(pci, chip);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: readahead: fix NULL filp dereference
Next: [PATCH 1/3] arch/powerpc/platforms: Eliminate use after free