readahead: fix NULL filp dereference
in [Kernel]
|
Prev: [PATCH 2.6.34] mfd: Clean up after WM83xx AUXADC interrupt if it arrives late
Next: [PATCH 3/3] sound/pci: Eliminate use after free
From: Kirill A. Shutemov on 2 Apr 2010 08:20 On Fri, Apr 2, 2010 at 10:27 AM, Wu Fengguang <fengguang.wu(a)intel.com> wrote: > The btrfs relocate_file_extent_cluster() calls us with NULL filp: > > [ 4005.426805] BUG: unable to handle kernel NULL pointer dereference at 00000021 > [ 4005.426818] IP: [<c109a130>] page_cache_sync_readahead+0x18/0x3e > > CC: Yan Zheng <yanzheng(a)21cn.com> > Reported-by: Kirill A. Shutemov <kirill(a)shutemov.name> > Signed-off-by: Wu Fengguang <fengguang.wu(a)intel.com> > --- > > Andrew and Greg: > > This is an obvious correct bug fix for .34 and .33-stable, > so I'm resending it directly to you without Kirill's confirmation. Sorry. Tested-by: Kirill A. Shutemov <kirill(a)shutemov.name> > --- sound-2.6.orig/mm/readahead.c 2010-03-26 11:51:57.000000000 +0800 > +++ sound-2.6/mm/readahead.c 2010-03-26 11:52:11.000000000 +0800 > @@ -502,7 +502,7 @@ void page_cache_sync_readahead(struct ad > return; > > /* be dumb */ > - if (filp->f_mode & FMODE_RANDOM) { > + if (filp && (filp->f_mode & FMODE_RANDOM)) { > force_page_cache_readahead(mapping, filp, offset, req_size); > return; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |