Prev: streaming replication breaks horribly if master crashes
Next: Explicit psqlrc
From: Brent Dombrowski on 16 Jun 2010 21:31
I have not been able to find any comments or discussion on this patch.

Contents and Purpose:
================
This patch removes duplicate code in opclasscmds.c. It removes the
duplicate code from DefineOpFamily by calling CreateOpFamily.

No new regression test or documentation are included with the patch.
Since it is not adding, removing, or changing any functionality, they
are most likely not necessary. The function call parameters remain the same.

Initial Run
========
The patch applied cleanly to HEAD. The regression tests pass both before
and after the patch.

Performance
=========
No changes in performance were observed. I do not have an appropriate
setup to properly test for performance impacts. Since this changes a
define function, I would not expect it to be frequently used.

Conclusion
========
The patch eliminates duplicate code as expected.

Brent Dombrowski



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 15 Jul 2010 20:16
Brent Dombrowski <brent.dombrowski(a)gmail.com> writes:
> [ review of KaiGai-san's patch ]

Committed. Thanks for the patch, and the review.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 | 
Pages: 1
Prev: streaming replication breaks horribly if master crashes
Next: Explicit psqlrc