From: Ion-Mihai Tetcu on
On Sun, 28 Mar 2010 13:09:38 -0600 (MDT)
Warren Block <wblock(a)wonkity.com> wrote:

> On Sun, 28 Mar 2010, Ion-Mihai Tetcu wrote:
>
> > Before reporting failures, please take a look at ports@ list, and
> > http://qat.tecnik93.com/index.php?action=failed_buildports&sort=last_built
> > to find out if the problem hasn't already been reported or even
> > fixed. We also have two incremental builds on Pointy to catch the
> > problems.
>
> wxgtk26 needs the same patch as wxgtk28:
>
> --- Makefile.orig 2010-03-28 12:52:41.000000000 -0600
> +++ Makefile 2010-03-28 12:54:17.000000000 -0600
> @@ -91,6 +91,7 @@
> post-patch:
> @${REINPLACE_CMD} -e 's|pkg_config_args
> --cflags|pkg_config_args pangox --cflags|g ; \ s|pkg_config_args
> --libs|pkg_config_args pangox --libs|g' \
> + -e 's|png_check_sig|png_sig_cmp|g' \
> ${WRKSRC}/configure
>
> .include <bsd.port.mk>
>
> ...although adding another -e option instead of just extending the
> existing one seems unnecessary.

Committed, thanks!

--
IOnut - Un^d^dregistered ;) FreeBSD "user"
"Intellectual Property" is nowhere near as valuable as "Intellect"
FreeBSD committer -> itetcu(a)FreeBSD.org, PGP Key ID 057E9F8B493A297B
From: Warren Block on
On Sun, 28 Mar 2010, Ion-Mihai Tetcu wrote:

> On Sun, 28 Mar 2010 13:09:38 -0600 (MDT)
> Warren Block <wblock(a)wonkity.com> wrote:
>
>> On Sun, 28 Mar 2010, Ion-Mihai Tetcu wrote:
>>
>>> Before reporting failures, please take a look at ports@ list, and
>>> http://qat.tecnik93.com/index.php?action=failed_buildports&sort=last_built
>>> to find out if the problem hasn't already been reported or even
>>> fixed. We also have two incremental builds on Pointy to catch the
>>> problems.

Okay, a few more... Warning: these are nearly untested. After all, if
it builds, it means it works, right?

Broken, not yet investigated:

graphics/enblend
graphics/gimp-app
graphics/hugin


Broken but fixable:

x11/xfce4-conf
won't build with GTKDOC enabled (problem with gtkdoc-fixxref, maybe
not png related)
also sent to maintainer oliver(a)freebsd.org

x11-fm/thunar
needs patch: files/patch-thunar-vfs-thunar-vfs-thumb.c
based on http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt
also sent to maintainer oliver(a)freebsd.org

--- thunar-vfs/thunar-vfs-thumb.c.orig 2010-03-28 13:50:55.000000000 -0600
+++ thunar-vfs/thunar-vfs-thumb.c 2010-03-28 13:51:39.000000000 -0600
@@ -1169,7 +1169,7 @@
goto done0;

/* verify the png signature */
- if (G_LIKELY (png_check_sig ((png_bytep) signature, sizeof (signature))))
+ if (G_LIKELY (png_sig_cmp ((png_bytep) signature, 0, sizeof (signature)) == 0))
rewind (fp);
else
goto done0;


-Warren Block * Rapid City, South Dakota USA
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: =?UTF-8?B?RnLDqWTDqXJpYw==?= Perrin on
Hello,

emacs23 is also broken. The build fails when building temacs with:

cc -nostdlib `./prefix-args -Xlinker -L/usr/local/lib -znocombreloc` -L/usr/local/lib -lintl -Wl,-znocombreloc -L/usr/local/lib -o temacs pre-crt0.o /usr/lib/crt1.o /usr/lib/crti.o /usr/lib/crtbegin.o dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o fringe.o image.o gtkutil.o dbusbind.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexelf.o bytecode.o process.o callproc.o region-cache.o sound.o atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o xfont.o ftfont.o xftfont.o ftxfont.o terminfo.o lastfile.o gmalloc.o vm-limit.o -L/usr/local/lib -pthread -L/usr/local/lib -
lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lXext -lXrender -lXinerama -lXi -lXrandr -lXcursor -lXcomposite -lXdamage -lpangoft2-1.0 -lXfixes -lcairo -lX11 -lpango-1.0 -lm -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lpthread -lSM -lICE -ltiff -ljpeg -lpng -lz -lm -lungif -lXpm -lX11 -L/usr/local/lib -lXft -lXrender -lfontconfig -lfreetype -lX11 -pthread -L/usr/local/lib -lrsvg-2 -lgdk_pixbuf-2.0 -lm -lcairo -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -pthread -L/usr/local/lib -ldbus-1 -lutil -lncurses -L/usr/local/lib -lz -lotf -lfreetype -L/usr/local/lib -lm17n-flt -lm17n-core -lm -lgcc -lc -lgcc /usr/lib/crtend.o /usr/lib/crtn.o
image.o(.text+0x65d3): In function `png_load':
: undefined reference to `png_check_sig'
image.o(.text+0x6c01): In function `png_load':
: undefined reference to `png_check_sig'
gmake[1]: *** [temacs] Error 1

The compilation of image.c itself works fine, with only a warning about a deprecated symbol:

cc -c -I/usr/X11R6/include -I/usr/local/include -L/usr/local/lib -I/usr/local/include -Demacs -DHAVE_CONFIG_H -I. -I/usr/ports/editors/emacs/work/emacs-23.1/src -I/usr/X11R6include -I/usr/local/include -L/usr/local/lib -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include/librsvg-2 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/gtk-2.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -O2 -pipe -fno-strict-aliasing -I/usr/local/include/fr
eetype2 -I/usr/local/include -I/usr/local/include image.c
image.c: In function 'my_png_error':
image.c:5885: warning: 'jmpbuf' is deprecated (declared at /usr/local/include/libpng/png.h:1090)
image.c: In function 'png_load':
image.c:6061: warning: 'jmpbuf' is deprecated (declared at /usr/local/include/libpng/png.h:1090)


--
Fred
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Tim Kellers on
> On Sun, 28 Mar 2010, Ion-Mihai Tetcu wrote:
>
> Before reporting failures, please take a look at ports@ list, and
> http://qat.tecnik93.com/index.php?action=failed_buildports&sort=last_built
>
> to find out if the problem hasn't already been reported or even
> fixed. We also have two incremental builds on Pointy to catch the
> problems.

Not on the webpage above, and running 7.3-STABLE

uname -a:
njtransit.njit.edu 7.3-STABLE FreeBSD 7.3-STABLE #0: Sun Mar 28 01:04:27
EDT 2010 root(a)njtransit.njit.edu:/usr/obj/usr/src/sys/NJT328 amd64

In graphics/ming, while portupgrading -fr png


In file included from decompile.c:7:
/usr/include/stdio.h:432:1: warning: this is the location of the
previous definition
cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
-I. -I.. -I../src -c main.c
cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
-I. -I.. -I../src -c parser.c
cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
-I. -I.. -I../src -c read.c
cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
-I. -I.. -I../src -L. -L.. -L/usr/local/lib -L.. -lming -lz -lm -lungif
-lpng -DNODECOMPILE action.o blocktypes.o decompile.o main.o parser.o
read.o outputtxt.c -o listswf
.../libming.so: undefined reference to `png_check_sig'
*** Error code 1


Tim Kellers

_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Tim Kellers on
Tim Kellers wrote:
>> On Sun, 28 Mar 2010, Ion-Mihai Tetcu wrote:
>>
>> Before reporting failures, please take a look at ports@ list, and
>> http://qat.tecnik93.com/index.php?action=failed_buildports&sort=last_built
>>
>> to find out if the problem hasn't already been reported or even
>> fixed. We also have two incremental builds on Pointy to catch the
>> problems.
>
> Not on the webpage above, and running 7.3-STABLE
>
> uname -a:
> njtransit.njit.edu 7.3-STABLE FreeBSD 7.3-STABLE #0: Sun Mar 28
> 01:04:27 EDT 2010
> root(a)njtransit.njit.edu:/usr/obj/usr/src/sys/NJT328 amd64
>
> In graphics/ming, while portupgrading -fr png
>
>
> In file included from decompile.c:7:
> /usr/include/stdio.h:432:1: warning: this is the location of the
> previous definition
> cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
> -I. -I.. -I../src -c main.c
> cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
> -I. -I.. -I../src -c parser.c
> cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
> -I. -I.. -I../src -c read.c
> cc -O2 -fno-strict-aliasing -pipe -I. -I.. -I/usr/local/include -Wall
> -I. -I.. -I../src -L. -L.. -L/usr/local/lib -L.. -lming -lz -lm
> -lungif -lpng -DNODECOMPILE action.o blocktypes.o decompile.o main.o
> parser.o read.o outputtxt.c -o listswf
> ../libming.so: undefined reference to `png_check_sig'
> *** Error code 1
>
>
> Tim Kellers
>
>

Looks like the/usr/ports/graphics/ming/files/patch-src_blocks_pngdbl.c
commit fixed ming.

Tim Kellers
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"