Prev: Documentation/: it's -> its where appropriate
Next: [git pull] drm-intel fixes for 2.6.34-rc4
From: Larry Finger on 22 Apr 2010 18:00
On 04/22/2010 04:37 PM, Roel Van Nyen wrote:
> Fix coding style errors
>
> Signed-off-by: Roel Van Nyen <roel.vannyen(a)gmail.com>
>
> ---
>
> drivers/staging/rtl8187se/r8180_rtl8225z2.c | 58 ++++++++++++++-------------
>
> 1 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> index 6edf5a4..9c38b3a 100644
>
> --- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> +++ b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> @@ -225,7 +225,7 @@ static void rtl8225_SetTXPowerLevel(struct net_device *dev, short ch)
>
> }
>
>
>
> static const u8 rtl8225z2_threshold[] = {
> <========================= HERE
> - 0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
>
> + 0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
>
> };

NACK: This patch is badly broken. All of the blank lines like the one I
marked above fail.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Roel Van Nyen on 23 Apr 2010 03:20
Greg KH wrote:

> On Thu, Apr 22, 2010 at 11:37:35PM +0200, Roel Van Nyen wrote:
>
>> Fix coding style errors
>>
>> Signed-off-by: Roel Van Nyen <roel.vannyen(a)gmail.com>
>>
>> ---
>>
>> drivers/staging/rtl8187se/r8180_rtl8225z2.c | 58 ++++++++++++++-------------
>>
>> 1 files changed, 30 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>>
>> index 6edf5a4..9c38b3a 100644
>>
>> --- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>>
>> +++ b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>>
>
> Very wierd, your email client doubled all of the lines.
>
> Did you use git send-email to send this patch, or did you cut-and-paste
> into gmail? If the latter, please don't :)
>
> thanks,
>
> greg k-h
>

Hi
I used thunderbird with the instructions provided by Documentation/email-clients.txt but I probably have missed something, I will try resending with git send-email.

thanks,
Roel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Documentation/: it's -> its where appropriate
Next: [git pull] drm-intel fixes for 2.6.34-rc4