From: Linus Torvalds on
On Fri, Aug 6, 2010 at 12:45 PM, Alan Cox <alan(a)lxorguk.ukuu.org.uk> wrote:
>
> Wouldn't it make more sense to simply turn it on as Linus suggested ?

I really do want the whole "there can be only one" highlander part.

Go all Christopher Lambert on it, and cut it off at the head so that
it cannot resurface even by mistake. IOW, remove the config option
entirely, and remove the #ifdef's that switch between the BKL and
mutex case.

Otherwise somebody will enable the BKL code, and we'll miss the
testing for that case. And getting testing is what the whole merge
window is all about.

I also don't want the BKL to show up in grep, even if the config
option for it were to be impossible to enable. If we've gotten far
enough that we can get rid of the BKL in the tty layer, we really
should get rid of it. Not leave it in some zombie limbo state.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on
On Friday 06 August 2010 21:38:36 Linus Torvalds wrote:
> I also don't want the BKL to show up in grep, even if the config
> option for it were to be impossible to enable. If we've gotten far
> enough that we can get rid of the BKL in the tty layer, we really
> should get rid of it. Not leave it in some zombie limbo state.

Ok, I've sent the replacement patch that does this, and I'm much
happier with the outcome.

If you apply this version, the only stronghold left for the BKL
will be fs/lockd, everything else that's left is either simple
to fix or highly obscure.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on
On Fri, Aug 6, 2010 at 12:58 PM, Arnd Bergmann <arnd(a)arndb.de> wrote:
>
> If you apply this version, the only stronghold left for the BKL
> will be fs/lockd, everything else that's left is either simple
> to fix or highly obscure.

Didn't we have patches for fs/lockd/ too? Or am I just confused with
the fs/locks.c patches?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on
On Friday 06 August 2010 22:11:46 Linus Torvalds wrote:
> On Fri, Aug 6, 2010 at 12:58 PM, Arnd Bergmann <arnd(a)arndb.de> wrote:
> >
> > If you apply this version, the only stronghold left for the BKL
> > will be fs/lockd, everything else that's left is either simple
> > to fix or highly obscure.
>
> Didn't we have patches for fs/lockd/ too? Or am I just confused with
> the fs/locks.c patches?

I had a ten-year old patch from Willy that takes care of fs/locks.c,
but we can't apply that without also taking care of fs/lockd.

I first didn't realize this when I sent that patch.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on
On Fri, Aug 06, 2010 at 09:58:45PM +0200, Arnd Bergmann wrote:
> On Friday 06 August 2010 21:38:36 Linus Torvalds wrote:
> > I also don't want the BKL to show up in grep, even if the config
> > option for it were to be impossible to enable. If we've gotten far
> > enough that we can get rid of the BKL in the tty layer, we really
> > should get rid of it. Not leave it in some zombie limbo state.
>
> Ok, I've sent the replacement patch that does this, and I'm much
> happier with the outcome.
>
> If you apply this version, the only stronghold left for the BKL
> will be fs/lockd, everything else that's left is either simple
> to fix or highly obscure.

Ok, I got that one now, and am building the tree to test here before
sending to Linus.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/