TTY patches for 2.6.36
in [Kernel]
|
Prev: GSoC 2010 - Memory hotplug support for Xen guests - second fully working version - once again
Next: [18/34] iwlwifi: fix scan abort
From: Greg KH on 6 Aug 2010 15:00 On Fri, Aug 06, 2010 at 11:40:15AM -0700, Linus Torvalds wrote: > > Do do the highlander thing on that crud. Cut it off at the head, and > make sure it never ever comes back to life. Arnd and Alan, I'll drop the BKL portion of this patch series and regenerate something to get the other tty patches to Linus. Care to redo the patch series and just drop the BKL for good? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 6 Aug 2010 15:10 On Thu, Aug 5, 2010 at 2:35 PM, Greg KH <gregkh(a)suse.de> wrote: > > This contains the big BKL removal of the tty layer, which has been > worked on now for a long time by Alan and Arnd. Umm. No it doesn't. It contains some crazy "BKL or mutex" choice layer, and the MUTEX choice is disabled unless you have EXPERIMENTAL set (and not the default even if it is set - but quite frankly, that doesn't matter, because asking about it is so fundamentally wrong in the first place that the whole default choice is totally meaningless). That's just total and utter crud. Having a conditional BKL is _worse_ than just having the BKL. It's crazy. It's stupid, it limits testing, and it's pure idiocy. Whoever thought that was a good idea was not thinking at all. Either the locking fixes are improvements, or they aren't. If they are improvements, they should be unconditionally enabled, and the old locking should have been removed. And if they aren't, it shouldn't have been merged at all. The timid kind of "let the user choose" choice is STUPID. Dammit, if the developer doesn't know which one is better, how the hell is a user supposed to know? Answer: he isn't. Making it a config option is fundamentally wrong. Config options that ask questions that users cannot answer are WRONG. Really. I'm not pulling crazy sh*t like this. The _only_ thing that kconfig option does is basically mean that it doesn't get the kind of coverage in testing that it needs to get, and it confuses everybody. Not to mention having two totally different code-paths where there should be only one. Do do the highlander thing on that crud. Cut it off at the head, and make sure it never ever comes back to life. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 6 Aug 2010 15:40 On Fri, 6 Aug 2010 11:51:47 -0700 Greg KH <gregkh(a)suse.de> wrote: > On Fri, Aug 06, 2010 at 11:40:15AM -0700, Linus Torvalds wrote: > > > > Do do the highlander thing on that crud. Cut it off at the head, and > > make sure it never ever comes back to life. > > Arnd and Alan, I'll drop the BKL portion of this patch series and > regenerate something to get the other tty patches to Linus. Wouldn't it make more sense to simply turn it on as Linus suggested ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 6 Aug 2010 15:40 On Fri, Aug 06, 2010 at 08:45:52PM +0100, Alan Cox wrote: > On Fri, 6 Aug 2010 11:51:47 -0700 > Greg KH <gregkh(a)suse.de> wrote: > > > On Fri, Aug 06, 2010 at 11:40:15AM -0700, Linus Torvalds wrote: > > > > > > Do do the highlander thing on that crud. Cut it off at the head, and > > > make sure it never ever comes back to life. > > > > Arnd and Alan, I'll drop the BKL portion of this patch series and > > regenerate something to get the other tty patches to Linus. > > Wouldn't it make more sense to simply turn it on as Linus suggested ? That's fine with me, and drop the option entirely? Arnd, any objection to that? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on 6 Aug 2010 15:50
On Friday 06 August 2010 20:51:47 Greg KH wrote: > On Fri, Aug 06, 2010 at 11:40:15AM -0700, Linus Torvalds wrote: > > > > Do do the highlander thing on that crud. Cut it off at the head, and > > make sure it never ever comes back to life. > > Arnd and Alan, I'll drop the BKL portion of this patch series and > regenerate something to get the other tty patches to Linus. > > Care to redo the patch series and just drop the BKL for good? > I'm sending you a new version of patch 43, everything else should just remain the same AFAICT. I've given it a quick sniff test and it still works the same way as the kernel I've been running for the past months with CONFIG_TTY_MUTEX enabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |