USB: gadget: mass/file storage: set serial number
in [Kernel]
|
Prev: USB: gadget: mass storage: use proper device class in device desc
Next: Report for 2.6.35-rc3-00262-g984bc96
From: David Brownell on 19 Jul 2010 10:50 > In that case, should all the composite gadgets stop > setting > the iManufacturer, iProduct Certainly not. Those are interface constants that don't relate to device instances. Every instance of those gadgets should appear the same (except for instance-specific state like serial#). and iSerialNumber? .... that's an instance-specific thing which should be managed properly. The kernel can't do that, but userspace can (ensuring the USB host always sees unique serial IDs for devices). > My understanding > is that the composite module parameters are only meant as a way > to override what the module uses as default. They're meant as a way to specify values that may not otherwise have been specified, or which need to be overridden. Standard module param behavior. > > >> As a matter of fact, without this patch, the > >> iSerialNumber module parameter won't work > > > So submit a bugfix for that alone, making it > > work everywhere... > > iSerialNumber not working is not the main issue. The > main issue > is that the serial number is not set by default > which makes Windows sad (Windows uses serial > number to distinguish different > devices with the same vendor and product ID). The > serial number > has to be set by default without the need for user to give Bullcrap. Do you understand the basic concept of "managed identifiers"?? Like serial numbers. They need to be explicitly managed to be unique. So for example two Linux-USB peripherals must never re-use the same ID. The way to do that is just not commit the user error of forgetting to assign one (or assigning a duplicate). > > As you see, the iSerialNumber module parameter > is ignored unless the > gadget driver sets the iSerialNumber field of > the device descriptor. > So make that gadget code do that ... as I said, fix such bugs, don't add more breakage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 19 Jul 2010 11:10 >> As you see, the iSerialNumber module parameter >> is ignored unless the >> gadget driver sets the iSerialNumber field of >> the device descriptor. On Mon, 19 Jul 2010 16:44:55 +0200, David Brownell <david-b(a)pacbell.net> wrote: > So make that gadget code do that ... That's exactly what I have done. I have added a code that sets the iSerialNumber. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Stern on 19 Jul 2010 12:20 On Mon, 19 Jul 2010, [utf-8] Michał Nazarewicz wrote: > > I have lost track of the current state of that patch. When you finish > > updating it, please post it for my review. > > This is still the v3 patchset (only the first two should be of > interest to you), still want me to resend? Or provide a URL for them in the mailing list archives. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 19 Jul 2010 12:30 >>> I have lost track of the current state of that patch. When you finish >>> updating it, please post it for my review. > On Mon, 19 Jul 2010, Michal‚ Nazarewicz wrote: >> This is still the v3 patchset (only the first two should be of >> interest to you), still want me to resend? On Mon, 19 Jul 2010 18:14:01 +0200, Alan Stern wrote: > Or provide a URL for them in the mailing list archives. 1/3: http://lkml.org/lkml/2010/7/8/317 Adds serial to mass storage gadget and g_multi introducing fsg_string_serial_fill() macro used by abovementioned gadgets and file storage gadget. 2/3: http://lkml.org/lkml/2010/7/8/318 Modification of Yann Cantin's patch, delta in comment for 1/3. 3/3: http://lkml.org/lkml/2010/7/8/316 Modification of patch for earlier patch for g_multi. Dunno if you want to look at it. Providing URL for completeness. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Stern on 19 Jul 2010 13:10
On Mon, 19 Jul 2010, [utf-8] Michał Nazarewicz wrote: > >>> I have lost track of the current state of that patch. When you finish > >>> updating it, please post it for my review. > > > On Mon, 19 Jul 2010, Michal‚ Nazarewicz wrote: > >> This is still the v3 patchset (only the first two should be of > >> interest to you), still want me to resend? > > On Mon, 19 Jul 2010 18:14:01 +0200, Alan Stern wrote: > > Or provide a URL for them in the mailing list archives. > > 1/3: http://lkml.org/lkml/2010/7/8/317 > Adds serial to mass storage gadget and g_multi introducing > fsg_string_serial_fill() macro used by abovementioned > gadgets and file storage gadget. Ah, yes. My personal taste would be to write fsg_string_serial_fill_n as an inline routine instead of as a macro, and not try to make it separate from fsg_string_serial_fill. > 2/3: http://lkml.org/lkml/2010/7/8/318 > Modification of Yann Cantin's patch, delta in comment for 1/3. I have only one objection to this patch: The new parameter's name should be "serial", not "serial_parm". (Compare it to all the other parameter names.) > 3/3: http://lkml.org/lkml/2010/7/8/316 > Modification of patch for earlier patch for g_multi. Dunno if > you want to look at it. Providing URL for completeness. No comment on that one. As for the discussion between you and David... I haven't tried to follow the details very carefully. I get the impression that the two of you are talking past each other instead of coming to grips with a genuine issue. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |