attoptions
in [PgSql]
|
From: Alex Hunsaker on 21 Jan 2010 10:24 On Thu, Jan 21, 2010 at 07:30, Robert Haas <robertmhaas(a)gmail.com> wrote: > On Thu, Jan 21, 2010 at 12:57 AM, Alex Hunsaker <badalex(a)gmail.com> wrote: >> Seems to me a comment about the above might be nice. Â Something like >> /* Things after here are should always be default null */ in >> pg_attribute.h ? > > Well... that wouldn't actually be a correct summary, so no. Â The point > is that variable-length fields are not used in tuple descriptors. > I'll add a comment about that. Yes that sounds much better, I was struggling to find the words. What I was trying to express was something along the lines of you cant have a non null value after these because you cant statically initialize them in genbki. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 22 Jan 2010 13:04 On Thu, Jan 21, 2010 at 10:24 AM, Alex Hunsaker <badalex(a)gmail.com> wrote: > On Thu, Jan 21, 2010 at 07:30, Robert Haas <robertmhaas(a)gmail.com> wrote: >> On Thu, Jan 21, 2010 at 12:57 AM, Alex Hunsaker <badalex(a)gmail.com> wrote: >>> Seems to me a comment about the above might be nice. Something like >>> /* Things after here are should always be default null */ in >>> pg_attribute.h ? >> >> Well... that wouldn't actually be a correct summary, so no. The point >> is that variable-length fields are not used in tuple descriptors. >> I'll add a comment about that. > > Yes that sounds much better, I was struggling to find the words. What > I was trying to express was something along the lines of you cant have > a non null value after these because you cant statically initialize > them in genbki. Committed. Thanks for the very thorough review. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
First
|
Prev
|
Pages: 1 2 3 Prev: PG_MODULE_MAGIC checks and pg_migrator Next: Streaming replication, loose ends |